Skip to content

Move rerun.components.blueprint.Visible to rerun.components.Visible #9067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 17, 2025

Related

  • this turned out to be necessary in order to address Handle visibility of multi-scalar time/point series #9021
    • we want per-series visibility and introducing a new component for that would be very much counter to our vision of handling "scoping" with tags (whereas component names are about (as far as possible) context agnostic semantics)

What

Surprisingly little friction on this. Originally wanted to add a migration guide entry for this, but it practically doesn't affect user interface (which is a bad thing! we have an open issue that it's hard/not possible to control visibility in blueprint code!)

@Wumpf Wumpf added include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Feb 17, 2025
Copy link

github-actions bot commented Feb 17, 2025

Latest documentation preview deployed successfully.

Result Commit Link
a131ab2 https://landing-7rlcfuju1-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Feb 17, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a131ab2 https://rerun.io/viewer/pr/9067 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Feb 18, 2025

Need to have a look at those link errors, they complain about Visible component!

@Wumpf Wumpf merged commit f2379e0 into main Feb 18, 2025
40 of 41 checks passed
@Wumpf Wumpf deleted the andreas/make-visible-regular-component branch February 18, 2025 11:14
@emilk emilk mentioned this pull request Apr 11, 2025
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants