Fix inconsistencies in plot highlights #9061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
force-pushed
the
andreas/plot-hover-sync
branch
from
3de8d27 to
85c7000
Compare
Wumpf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
PlotResponse::hovered_plot_itemalso set when hovering the legend emilk/egui_plot#81What
Noticed these issues while looking into solving
I noticed that syncing of highlights is also all over the place. Seemed related enough to sort it out right away!
Screen.Recording.2025-02-17.at.16.15.00.mov
Drawback is that for some already large markers this may be a bit too noisy:
Screen.Recording.2025-02-17.at.16.16.05.mov
But I believe it's the right tradeoff!
Internally it also moves over to
InstancePathoverEntityPathfor plot association in order to handle multi-scalar cases without surprises.