First iteration of a dedicated UI and communication for the Redap server/catalog/collection browser #9018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
abey79
changed the title
abey79
added
ui
abey79
force-pushed
the
antoine-andreas/catalog-in-viewer
branch
from
5fc2a02 to
e1547d7
Compare
abey79
changed the base branch from
main
to
antoine/component_descriptor_ref
abey79
added a commit
that referenced
this pull request
Feb 16, 2025
### Related * Related to #9034 * Required for #9018 ### What This PR introduce the `ComponentDescriptorRef` type to `re_sorbet`. It's like `ComponentDescriptor` but: - It has refs instead of owned copies. - It has a `RowId` enum (which would be difficult to add to `ComponentDescriptor` because of the ramifications on the dataframe API—let's wait for the RowID <-> Index column merge for that).
abey79
force-pushed
the
antoine-andreas/catalog-in-viewer
branch
from
e1547d7 to
778edd8
Compare
# Conflicts: # crates/viewer/re_component_ui/src/recording_uri.rs # crates/viewer/re_viewer_context/src/lib.rs
# Conflicts: # crates/store/re_grpc_client/src/redap/address.rs # crates/store/re_grpc_client/src/redap/mod.rs
grtlr
approved these changes
Feb 17, 2025
Comment on lines
386
to
389
| let datastore_view_active = datastore_ui.ui(&ctx, ui, app_options.time_zone); | ||
| if !datastore_view_active { | ||
| *display_mode = DisplayMode::Viewer; | ||
| } |
There was a problem hiding this comment.
This took me a while to figure out (see comment above)—mostly because of the &mut bool in chunk_store_ui. Wonder if we should propagate the change of just returning a bool to that method as well.
There was a problem hiding this comment.
I've named/commented stuff to be more explicit.
There was a problem hiding this comment.
This chunk store ui could benefit from a refactor based on a command queue. But that's for another day.
# Conflicts: # crates/store/re_grpc_client/src/redap/mod.rs
abey79
added
the
feat-redap-browser
abey79
added a commit
that referenced
this pull request
Feb 18, 2025
### Related - Follow-up to #9018 ### What So far, clicking on a recording URI in the redap browser would silently load the recording in the background. With this PR, the UI switches back to viewer mode whenever a new recording is loaded, unless the user cmd/ctrl- or middle-clicked the link, in which case the UI remains in redap browser mode (mimicking the load tab in the background behaviour of browser). This involved a number of changes: - `RecordingUri` is now removed, because the default `arrow_ui` handling of links is sufficient. - `rerun://` links are globally handled by the viewer, taking into account the same-tab/new-tab behaviour in egui `OpenUrl` event. - `ui.re_hyperlink` can now be specified is the new-tab behaviour is forced or not. It is the case for our documentation link, but not for generic urls (e.g. from `arrow_ui()` - Some cleanup around `redap::Scheme` happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Implement a whole new Redap server/catalog/collection UI.