AsComponents::serialize
is now AsComponents::as_batches
and returns Collection<ComponentBatch>
#8884
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See title. This is a breaking change for custom
AsComponents
implementations. But we had plenty of breaking changes in that area, so now it's the right time.The rename
serialize
toas_batches
is motivated by the fact that previously we typically did to-arrow serializations inAsComponents
. This is no longer the case and it's more of a collecting operation, just as we do in Rust'sAsComponents::as_serialized_batches
- since C++ only hasComponentBatch
and noSerializedComponentBatch
it follows that the method is just calledas_batches
now.The change in return type fixes an old todo (no ticket) for using
rerun::Collection
for more flexibility in this area (pending improvements torerun::Collection
) and making our API handling more consistent in that regard.