Skip to content

Filter entities in the UI (part 7): Refactor and optimize re_time_panel and add more tests #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 30, 2025
Merged

Filter entities in the UI (part 7): Refactor and optimize re_time_panel and add more tests #8863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0fc3aed
Minor clean-up
abey79 Jan 27, 2025
92f577c
Update existing tests with new `TestContext` api
abey79 Jan 27, 2025
d27f110
Add a new test suite to cover various configuration of entity/timelin…
abey79 Jan 27, 2025
9020b4b
Introduce streams tree data structures
abey79 Jan 27, 2025
cfd6e53
Update UI code to use `StreamsTreeData`
abey79 Jan 28, 2025
ed17619
Update test snapshot based on (desired) UI change
abey79 Jan 28, 2025
2183bf5
Lint
abey79 Jan 28, 2025
1cfc12d
Use faster method to determine if an entity has components
abey79 Jan 27, 2025
f65f3f5
Do not unnecessarily query for event data if those are not drawn
abey79 Jan 27, 2025
29bc041
Remove profile scope from `handle_select_hover_drag_interactions` as …
abey79 Jan 28, 2025
230a7dc
Move event count logic to inside the tooltip closure where it's needed
abey79 Jan 28, 2025
4d7b3d1
Do not query for event unnecessarily (again)
abey79 Jan 28, 2025
0c1eb2c
Addressed review comments
abey79 Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6570,6 +6570,7 @@ dependencies = [
"re_viewer_context",
"re_viewport_blueprint",
"serde",
"smallvec",
"vec1",
]

Expand Down
3 changes: 1 addition & 2 deletions crates/viewer/re_data_ui/src/item_ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ pub fn instance_path_icon(
if db
.storage_engine()
.store()
.all_components_on_timeline(timeline, &instance_path.entity_path)
.is_some()
.entity_has_data_on_timeline(timeline, &instance_path.entity_path)
{
&icons::ENTITY
} else {
Expand Down
1 change: 1 addition & 0 deletions crates/viewer/re_time_panel/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ itertools.workspace = true
nohash-hasher.workspace = true
once_cell.workspace = true
serde.workspace = true
smallvec.workspace = true
vec1.workspace = true

[dev-dependencies]
Expand Down
11 changes: 2 additions & 9 deletions crates/viewer/re_time_panel/src/data_density_graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
//! The data density is the number of data points per unit of time.
//! We collect this into a histogram, blur it, and then paint it.

use std::ops::RangeInclusive;
use std::sync::Arc;

use egui::emath::Rangef;
Expand Down Expand Up @@ -211,7 +210,6 @@ impl DensityGraph {
y_range: Rangef,
painter: &egui::Painter,
full_color: Color32,
hovered_x_range: RangeInclusive<f32>,
) {
re_tracing::profile_function!();

Expand Down Expand Up @@ -270,11 +268,8 @@ impl DensityGraph {
let inner_radius =
(max_radius * normalized_density).at_least(MIN_RADIUS) - feather_radius;

let inner_color = if hovered_x_range.contains(&x) {
Color32::WHITE
} else {
full_color.gamma_multiply(lerp(0.5..=1.0, normalized_density))
};
let inner_color = full_color.gamma_multiply(lerp(0.5..=1.0, normalized_density));

(inner_radius, inner_color)
};
let outer_radius = inner_radius + feather_radius;
Expand Down Expand Up @@ -417,8 +412,6 @@ pub fn data_density_graph_ui(
row_rect.y_range(),
time_area_painter,
graph_color(ctx, &item.to_item(), ui),
// TODO(jprochazk): completely remove `hovered_x_range` and associated code from painter
0f32..=0f32,
);

if tooltips_enabled {
Expand Down
Loading
Loading