-
Notifications
You must be signed in to change notification settings - Fork 451
ComponentBatch
doesn't implement AsComponents
anymore
#8820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12992792501 |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12994028275 |
410df5b
to
81bac95
Compare
Have something very very similar in progress in C++, so looks like we're aligned on how to go about this! |
This makes it impossible to pass something implementing
ComponentBatch
(i.e. some native data that knows how to serialized itself into arrow component data) directly toRecordingStream::log
.This forces the caller to either..:
my_data.serialized()
, which expose further custom-tagging facilities, orSimilarly, this removes all the legacy support infrastructure that was needed to carry
ComponentBatch
es all the way to the logger:log_component_batches
AsComponents::as_component_batches
ComponentBatchCow
,ComponentBatchCowWithDescriptor
, ...I think this is all that's needed in order to..:
At the very least, it makes sure that existing code that used to log
ComponentBatch
es directly breaks at compile-time.