Skip to content

Rust: remove legacy send_columns and update everything left #8804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 24, 2025

Title.

Copy link

github-actions bot commented Jan 24, 2025

Web viewer failed to build.

Result Commit Link Manifest
https://rerun.io/viewer/pr/8804 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc force-pushed the andreas/eager-serialization-cleanup branch from 6ad87af to 597d608 Compare January 24, 2025 14:31
Base automatically changed from andreas/eager-serialization-cleanup to main January 24, 2025 14:31
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Jan 24, 2025
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 24, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12951674294

@Wumpf Wumpf self-requested a review January 24, 2025 15:03
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 27, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12984824859

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 27, 2025

I missed examples/incremental_logging. I'll take care of that before merging.

@teh-cmc teh-cmc merged commit 8f5cbe1 into main Jan 27, 2025
16 checks passed
@teh-cmc teh-cmc deleted the cmc/rust_cleanup branch January 27, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants