Python: remove legacy send_columns and update everything left
#8799
Conversation
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
teh-cmc
force-pushed
the
cmc/tagged_columnar_apis_python
branch
4 times, most recently
from
1bbaba0 to
5570f8b
Compare
teh-cmc
force-pushed
the
cmc/python_columnar_cleanup
branch
2 times, most recently
from
26e7370 to
d68bb4b
Compare
teh-cmc
added
🐍 Python API
teh-cmc
changed the title
send_columns and update everything left
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12987658900 |
teh-cmc
force-pushed
the
cmc/python_columnar_cleanup
branch
from
6970ec1 to
2549a8b
Compare
| @@ -17,16 +17,16 @@ | |||
|
|
|||
| # Log the ImageFormat and indicator once, as static. | |||
| format_static = rr.components.ImageFormat(width=width, height=height, color_model="RGB", channel_datatype="U8") | |||
| rr.log("images", [format_static, rr.Image.indicator()], static=True) | |||
| rr.send_columns("images", indexes=[], columns=rr.Image.columns(format=format_static)) | |||
There was a problem hiding this comment.
Why not this here?
| rr.send_columns("images", indexes=[], columns=rr.Image.columns(format=format_static)) | |
| rr.log("images", rr.Image.update_fields(format=format_static), static=True) |
There was a problem hiding this comment.
So we can re-enable comparisons of the snippets between the 3 languages (mixing logging and sending has a non-deterministic order).
| @@ -67,3 +71,60 @@ def __init__( | |||
| return | |||
|
|
|||
| self.__attrs_clear__() | |||
|
|
|||
| @classmethod | |||
| def columns_seconds( | |||
There was a problem hiding this comment.
Surprising that this one is called columns_seconds while the other two are called milliseconds/nanoseconds. Any reason for that?
There was a problem hiding this comment.
oversight -- i meant for all of them to be prefixed with columns_
Title.