Fix compilation for GCC 13.3 (missing cstdint include)
#8609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
Wumpf
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
thanks!
Looks like our Ci doesn't catch this because it runs with an older compiler version
(GCC 12.4.0 according to https://github.com/rerun-io/rerun/actions/runs/12644596148/job/35232455314#step:7:19 whereas the ticket you've opened mentions 13.3.0).
Guess we'll have to improve our coverage at some point. Absolutely nuts that the "which include drags in which other include implicitly" still hasn't been standardized on C++.
Wumpf
changed the title
Wumpf
changed the title
cstdint include)
Wumpf
added
🪳 bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Closes #8608
What
Add cstdint to define uint64_t.