-
Notifications
You must be signed in to change notification settings - Fork 451
End-to-end tagging: basic helpers for Python & Rust #8332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12184588997 |
Wumpf
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
56ef384
to
77b1f3f
Compare
Base automatically changed from
cmc/investigating_component_descriptors_chunk_diff
to
main
December 9, 2024 09:54
Co-authored-by: Andreas Reich <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
5fd5244
to
ed1e775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🪵 Log & send APIs
Affects the user-facing API for all languages
🐍 Python API
Python logging API
🦀 Rust API
Rust logging API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce some very basic helpers so that overriding tags doesn't require a PhD.
The goal here is not great, it's simply not completely horrible.
Python
Before:
After:
Rust
Before:
After:
C++
Too complicated, @Wumpf and I made the wise decision of giving up 🙃