Skip to content

Fix video on web sometimes not showing last few frames for some videos #8117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Nov 13, 2024

What

Tested on top of #8111 in Chrome @ Windows with a video that would previously not show the last two frames.

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser include in changelog 🎞️ video labels Nov 13, 2024
@emilk emilk self-requested a review November 13, 2024 11:21
@emilk
Copy link
Member

emilk commented Nov 13, 2024

This makes me think we should call flush in the Av1 decoder too (https://docs.rs/dav1d/latest/dav1d/struct.Decoder.html#method.flush)

@Wumpf
Copy link
Member Author

Wumpf commented Nov 13, 2024

Confirmed working on Firefox @ Windows as well.
... but I got really weird behavior from Firefox there: it refused to play the video at all, was still fine with Av1 though. Then restarted Firefox and it played the video poorly (with massive wait times and getting stuck). Then opened app.rerun.io to check if that regressed. That played perfectly with last two frames missing. Then I opened a new tab again with the version I'm testing and it played perfectly through to the end. 🙈🙈🙈

@emilk emilk merged commit 7e513d1 into main Nov 13, 2024
46 checks passed
@emilk emilk deleted the andreas/fix-last-frames-missing branch November 13, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 🎞️ video 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants