Skip to content

Implement support for in-place drag-n-drop #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2024
Merged

Implement support for in-place drag-n-drop #7880

merged 8 commits into from
Oct 24, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 23, 2024 •
edited by github-actions bot
Loading

It is pretty tricky to get right (unsurprisingly) -- StoreIds and RecordingIds and SetStoreInfos are all pretty finicky constructs and a lot can go wrong when loading arbitrarily things in place. But it works pretty nicely overall!

24-10-23_16.25.46.patched.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added enhancement New feature or request 📺 re_viewer affects re_viewer itself include in changelog labels Oct 23, 2024
teh-cmc
teh-cmc commented Oct 23, 2024
View reviewed changes
crates/viewer/re_viewer/src/app.rs
Comment on lines +1292 to +1293
// NOTE: Relying on `self` is dangerous, as this is called during a time where some internal
// fields may have been temporarily `take()`n out. Keep this a static method.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ask me how I know, i dare you

teh-cmc
teh-cmc commented Oct 23, 2024
View reviewed changes
crates/viewer/re_viewer/src/app.rs
Comment on lines +1311 to +1312
// Don't redirect data to the welcome screen.
.filter(|&app_id| app_id != &StoreHub::welcome_screen_app_id())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

@teh-cmc teh-cmc mentioned this pull request Oct 23, 2024
Merged
6 tasks
zehiko
zehiko approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@zehiko zehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teh-cmc teh-cmc merged commit 91e981a into main Oct 24, 2024
34 checks passed
@teh-cmc teh-cmc deleted the cmc/fwd_opened_id branch October 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zehiko zehiko zehiko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send currently opened app & recording ID to data-loaders
2 participants
@teh-cmc @zehiko