Skip to content

Allow logging to a recording without first calling rr.init() #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Oct 11, 2024

What

Our recording functions would always check the global recording state even though they could validly operate just on a manually-created recording.

With this change, this becomes valid:

import rerun as rr

rec = rr.new_recording("rerun_example_cube_flat")

rec.log("points", rr.Points3D([1, 2, 3]))

rec.save("output.rrd")

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs marked this pull request as ready for review October 11, 2024 15:16
@teh-cmc teh-cmc merged commit ce65385 into main Oct 14, 2024
36 of 37 checks passed
@teh-cmc teh-cmc deleted the jleibs/explicit_recordings_work branch October 14, 2024 07:30
@emilk emilk changed the title Make explicit recordings work without calling rr.init() Allow logging without first calling rr.init() Oct 16, 2024
@emilk emilk changed the title Allow logging without first calling rr.init() Allow logging to a recording without first calling rr.init() Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants