Skip to content

Heuristically created blueprint overlaps encoded images #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wumpf opened this issue Feb 25, 2025 · 3 comments · Fixed by #9308
Closed

Heuristically created blueprint overlaps encoded images #9131

Wumpf opened this issue Feb 25, 2025 · 3 comments · Fixed by #9308
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working heuristics Heuristics for placing views, fallback provider, etc.

Comments

@Wumpf
Copy link
Member

Wumpf commented Feb 25, 2025

According to this report encoded images are by default put into the same view rather than spawning separate views.
@Wumpf Wumpf added heuristics Heuristics for placing views, fallback provider, etc. 🟦 blueprint The data that defines our UI 🪳 bug Something isn't working labels Feb 25, 2025
@slyfox3
Copy link

slyfox3 commented Mar 6, 2025

I'm also seeing the same, in c++. Is this a regression?

@slyfox3
Copy link

slyfox3 commented Mar 7, 2025

I realized if the image is logged with an pinhole model, the auto-layout puts each image into its own view. This could be an okay workaround, with an optional with_image_plane_distance(.0f) trick.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 7, 2025

This is independent of SDK languages as it's a bug in the viewer

@Wumpf Wumpf mentioned this issue Mar 17, 2025
Merged
Wumpf added a commit that referenced this issue Mar 18, 2025
@Wumpf
Speed up 2d spawn heuristic for many entities & fix heuristic creatin…
b726054 
…g overlapping views for `EncodedImage` (#9308)

### Related

* Addresses comment in
#8233 (comment)
* Fixes #9131

### What

Fixes excruciating slow heuristic for finding the right view roots for
2d images. This hit very hard for scenes with many entities containing
images.

Fixed heuristic incorrectly handling `EncodedImage` in the process.

For testing I applied this fix to 0.22.1 and tried the RRD provided
[here](#8233 (comment))
on a local release build. For my M1 Max Mac I get:

Before: `spawn_heuristics` for 2D takes 94ms 😱  
After:`spawn_heuristics` for 2D takes: 0.290ms

(branch with backported fix is
`andreas/0.22.1/andreas/fix-encodedimage-spawn-heurist-and-make-image-view-heuristics-faster`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working heuristics Heuristics for placing views, fallback provider, etc.
Projects
None yet
Milestone
No milestone
2 participants
@Wumpf @slyfox3