Skip to content

Anti aliasing for outlines of lines broke in 0.20 (working fine in 0.19) #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Wumpf opened this issue Dec 4, 2024 · 2 comments · Fixed by #8317
Closed

Anti aliasing for outlines of lines broke in 0.20 (working fine in 0.19) #8314

Wumpf opened this issue Dec 4, 2024 · 2 comments · Fixed by #8317
Labels
🪳 bug Something isn't working 🔺 re_renderer rendering, graphics, GPU 🦟 regression A thing that used to work in an earlier release

Comments

@Wumpf
Copy link
Member

Wumpf commented Dec 4, 2024

Image

Seems to affect all backends

Even even on WebGL - where we make some awful compromises in regards to outline anti-aliasing - it looked better on 0.19.0:
https://rerun.io/viewer/version/0.19.0?url=https%3A%2F%2Fapp.rerun.io%2Fversion%2F0.19.0%2Fexamples%2Fdna.rrd
@Wumpf Wumpf added 🔺 re_renderer rendering, graphics, GPU 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Dec 4, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Dec 4, 2024

Looks like this does not affect WebGL after all.

The difference here is that in WebGL we don't do custom anti aliasing by reading the MSAA samples in the shader.

WebGL 0.20
Image
WebGL 0.19
Image

WebGPU 0.20
Image
WebGPU 0.19
Image

@Wumpf Wumpf changed the title Anti aliasing for outlines broke in 0.20 (working fine in 0.19) Anti aliasing for outlines of lines broke in 0.20 (working fine in 0.19) Dec 4, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Dec 4, 2024

Turns out this is exclusively limited to outlines of lines

@Wumpf Wumpf mentioned this issue Dec 4, 2024
Merged
Wumpf added a commit that referenced this issue Dec 5, 2024
@Wumpf
Fix outlines for lines having more preceived aliasing since 0.20 (#8317)
c31cf27 
### Related

* Fixes #8314

### What

All screenshots on MacOS lowdpi (==scaling 100%) since it's easier to
spot there (but also still impactful on highdpi==scaling>=200%). Listing
WebGPU & WebGL separately since WebGL version doesn't do anti-aliasing
on outlines (technical limitations)

0.19 WebGPU Chrome

![image](https://github.com/user-attachments/assets/1e12d179-05a3-45b9-9de9-6b87a7c8484a)

0.20/main WebGPU Chrome

![image](https://github.com/user-attachments/assets/fe7fc1a5-90d0-4ba7-b787-5c499e5ee8fc)

This PR WebGPU Chrome

![image](https://github.com/user-attachments/assets/98df0047-a9bb-4a9d-9847-5c1275aa20b0)

---

0.19 WebGL Chrome

![image](https://github.com/user-attachments/assets/127c8bee-8ede-4d8a-baa6-81c2a90135b3)


0.20/main WebGL Chrome

![image](https://github.com/user-attachments/assets/7942509e-378d-4f19-b8bc-28117f673f26)


This PR WebGL Chrome

![image](https://github.com/user-attachments/assets/f62556eb-61ca-4d28-b069-1aee0e717bed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🔺 re_renderer rendering, graphics, GPU 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix outlines for lines having more preceived aliasing since 0.20 rerun-io/rerun
1 participant
@Wumpf