Skip to content

Clean-up the blueprint API for the map view #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abey79 opened this issue Oct 25, 2024 · 0 comments · Fixed by #8027
Closed

Clean-up the blueprint API for the map view #7903

abey79 opened this issue Oct 25, 2024 · 0 comments · Fixed by #8027
Labels
🟦 blueprint The data that defines our UI feat-map-view Everything related to the map view 🐍 Python API Python logging API

Comments

@abey79
Copy link
Member

abey79 commented Oct 25, 2024 •
edited
Loading

☝🏻
@abey79 abey79 mentioned this issue Oct 25, 2024
Closed
27 tasks
@abey79 abey79 added feat-map-view Everything related to the map view 🟦 blueprint The data that defines our UI 🐍 Python API Python logging API labels Oct 25, 2024
@abey79 abey79 mentioned this issue Oct 25, 2024
Merged
4 tasks
abey79 added a commit that referenced this issue Nov 7, 2024
@abey79
Improve the blueprint API for the map view
6bc7d42 
Fixes #7903
@abey79 abey79 mentioned this issue Nov 7, 2024
Merged
7 tasks
abey79 added a commit that referenced this issue Nov 7, 2024
@abey79
Improve the blueprint API for the map view (#8027)
477d97e 
### What

- Fixes #7903

In passing, I noticed we didn't have an easy way to test view blueprint
for equality, e.g. to verify the various way they can be constructed.
I've added an `__eq__` implementation on both `SpaceView` and
`Container` that ignores the `id` field (which is always unique).

- [x] add snippet/screenshot

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8027?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8027?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8027)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🟦 blueprint The data that defines our UI feat-map-view Everything related to the map view 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the blueprint API for the map view rerun-io/rerun
1 participant
@abey79