-
Notifications
You must be signed in to change notification settings - Fork 451
Double-click to focus on a point no longer works #5382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This was broken more or less intentionally. Starting in 0.13 double clicking an entity focuses the entity as a whole, no matter where you double click it. For this new focus action we're using the current local bounding box of that entity and move the camera accordingly. The previous double click in contrast was about a 3D position and would place the camera with some heuristic based on the current scene size. |
@Wumpf I see, our use case involves dealing with large point clouds and we often have to zoom in on very specific points. I don't know what's the most user-friendly way to have this feature back. The double click to focus on a specific 3D point feels natural and common in lots of 3D viewers. Could it be some kind of "focus mode" defined for each entity, that we could set automatically in a blueprint? That way the default behavior remains the one from v0.13.0, but we can easily go back to the old approach when needed for specific entities. |
Not thrilled by adding a mode setting for it, especially not per-entity. But I get that this can be quite important for your usecase so we'll have to come up with something 🤔 |
@Wumpf: yes, the extra mode would complexify the code and testing... Feel free to ping me if you need some feedback on potential solutions :) And thanks for the quick answer! |
### What This PR scrolls the dataframe view to the focused entity/instance. This would be further enhanced by addressing: - #6906 - #5382 https://github.com/user-attachments/assets/ee59960e-ec61-4f1c-ba99-89a6e726e040 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6908?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6908?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6908) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Describe the bug
Double-clicking on a 3D point of a point cloud to refocus the camera no longer works.
To Reproduce
Steps to reproduce the behavior:
Structure from Motion
)Expected behavior
Up until v0.12.1, we could focus specific points of a 3D point cloud easily, and this is no longer the case.
Screenshots
N/A
Backtrace
N/A
Desktop (please complete the following information):
Rerun version
Versions 0.13.0 to 0.14.1
Additional context
N/A
The text was updated successfully, but these errors were encountered: