Support light mode in the Rerun viewer

[edulecom]

Hello,

I'm playing with .\rerun\crates\re_ui\examples\re_ui_example.rs and I'm trying to change the theme to light.
I have added only one line in the fn update:

    egui::TopBottomPanel::bottom("bottom_panel")
        .frame(self.re_ui.bottom_panel_frame())
        .show_animated(egui_ctx, self.bottom_panel, |ui| {
            ui.strong("Bottom panel");
            egui::widgets::global_dark_light_mode_buttons(ui); // this line is added
        });  

Effect is strange: only central panel applies the theme. It can be seen in an attached video.
Any help would very appreciated.

2023-08-21.16-20-55.mp4

[Wumpf]

The out of the box theme settings are bound to not work properly in rerun as we sadly change a lot of the theming colors in Rerun on-the-fly. At least I suspect that's what's most of the issue here.

That said, (re)adding a light mode is something we want to do eventually.
Are you just trying out things or is a Rerun light theme something you'd like to have as well?

[edulecom]

Thank you for your response. I'm currently in the process of developing an app using re_ui, and while the absence of a light mode isn't a critical issue, having that feature would certainly be a welcome addition.

[emilk]

Most of the work has landed in #9953 but there are a few things left to do:

• Feature-complete:
  • Fix table headers (e.g. catalogs)
  • Fix breadcrumbs ui
• Stabilization
  • Remove the experimental warning
  • Switch the default theme to follow the system
  • Add light mode snapshot tests
  • Make sure ThemePreference is saved/restored properly