Skip to content

Exporting 2 different function under same name #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kuebk opened this issue Dec 2, 2013 · 1 comment
Closed

Exporting 2 different function under same name #7

kuebk opened this issue Dec 2, 2013 · 1 comment

Comments

@kuebk
Copy link
Contributor

kuebk commented Dec 2, 2013

I noticed that there are 2 different functions exported under same name, is it on purpose?

https://github.com/mikeal/aws-sign/blob/master/index.js#L126
https://github.com/mikeal/aws-sign/blob/master/index.js#L145
@KiaraGrouwstra
Copy link
Contributor

Somehow I think my build just errored because of this:

SyntaxError: Duplicate export 'queryStringToSign' (225:32) in PROJECT_PATH\node_modules\aws-sign2\index.js

... renaming the former export to stringToSign (as I presume would have been the intention) fixed this for me.

@mikeal mikeal closed this as completed in 03755f2 Oct 12, 2016
mikeal added a commit that referenced this issue Oct 12, 2016
@mikeal
Merge pull request #11 from tycho01/patch-1
270e16d 
fix duplicate export `queryStringToSign`, closes #7
@drawyan drawyan mentioned this issue Aug 16, 2017
Open
@abhiramhatolkar abhiramhatolkar mentioned this issue Dec 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuebk @KiaraGrouwstra