Skip to content

fix: swaps not working properly for ethers/ethers5 #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Apr 2, 2025

Description

Fixed an issue where swaps were not working properly when using the ethers/ethers5 adapter

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2588

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo 🛑 Canceled (Inspect) Apr 2, 2025 1:58pm
appkit-laboratory 🛑 Canceled (Inspect) 💬 Add feedback Apr 2, 2025 1:58pm
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-basic-ep-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-basic-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-basic-up-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-ethers5-bera ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-nansen-demo ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-vue-solana ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2025 1:58pm
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm
vue-wagmi-example ⬜️ Ignored (Inspect) Apr 2, 2025 1:58pm

Copy link

changeset-bot bot commented Apr 2, 2025

🦋 Changeset detected

Latest commit: 43ee901

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-adapter-ethers5 Patch
@reown/appkit Patch
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit-utils Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-common Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magiziz magiziz changed the title fix: swaps not working for ethers/ethers5 fix: swaps not properly for ethers/ethers5 Apr 2, 2025
Copy link
Contributor

github-actions bot commented Apr 2, 2025

Warnings
⚠️ File packages/appkit/src/client/appkit-base-client.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 43ee901

Copy link
Contributor

github-actions bot commented Apr 2, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.79% 24976 / 33391
🔵 Statements 74.79% 24976 / 33391
🔵 Functions 66.13% 2109 / 3189
🔵 Branches 83.17% 4804 / 5776
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/ethers5/src/utils/Ethers5Methods.ts 17.05% 50% 25% 17.05% 16-17, 19, 30-57, 60-88, 91-113, 116-134, 137-145, 148-153
packages/appkit/src/client/appkit-base-client.ts 72.37% 87.79% 76.84% 72.37% 164-165, 167-168, 173-174, 244-245, 281-287, 316-335, 338-376, 379-384, 401-405, 418-433, 458-464, 467-477, 480-492, 495-497, 500-502, 505-507, 510-512, 515-521, 524-527, 543-555, 561-594, 597-607, 661-662, 668, 679-693, 699-706, 719-723, 763-764, 805-809, 815-816, 828, 851-856, 922, 943-944, 950, 952-968, 973, 1012-1013, 1029-1030, 1035-1036, 1069-1076, 1121-1125, 1154-1157, 1161, 1177-1187, 1209-1220, 1249-1250, 1257-1258, 1262-1263, 1430-1431, 1451-1452, 1455-1456, 1471-1474, 1477-1478, 1498-1499, 1502-1503, 1523-1524, 1537, 1541, 1546-1565, 1568-1577, 1592-1593, 1636-1639, 1642-1643, 1731-1732, 1735-1738, 1741-1742, 1745-1746, 1749-1750, 1753-1754, 1757-1761, 1826-1837, 1846-1868, 1216, 1548-1569
Generated in workflow #10610 for commit 43ee901 by the Vitest Coverage Report Action

Copy link

linear bot commented Apr 2, 2025

Copy link
Contributor

@arein arein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested both ethers and ethers 5

swapped for each POL to USDC back and forth

@magiziz magiziz changed the title fix: swaps not properly for ethers/ethers5 fix: swaps not working properly for ethers/ethers5 Apr 2, 2025
@magiziz magiziz merged commit 542985c into main Apr 2, 2025
31 checks passed
@magiziz magiziz deleted the fix/ethers-swaps branch April 2, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants