fix: excludeWalletIds not working with bitcoin wallets
#4120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
magiziz
commented
Apr 1, 2025
Comment on lines
+66
to
+70
| const isNameExcluded = | ||
| Boolean(connector.name) && | ||
| ApiController.state.excludedWallets.some(wallet => | ||
| HelpersUtil.isLowerCaseMatch(wallet.name, connector.name) | ||
| ) |
There was a problem hiding this comment.
Bitcoin and solana doesn't have rdns so the only way to make sure they're excluded is to check by name
🦋 Changeset detectedLatest commit: b0dcf6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where
excludeWalletIdsoption wasn't properly filtering Bitcoin walletsType of change
Associated Issues
For Linear issues: Closes APKT-2548
Checklist