Skip to content

feat: bitget wallet connector (bitcoin) #4111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: bitget wallet connector (bitcoin) #4111

wants to merge 2 commits into from

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented Mar 31, 2025

Description

Added bitget wallet connector for bitcon

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes APKT-2510

Showcase (Optional)

image

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

Copy link

linear bot commented Mar 31, 2025

Copy link

changeset-bot bot commented Mar 31, 2025

🦋 Changeset detected

Latest commit: 7cde32a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@reown/appkit-adapter-bitcoin Patch
@reown/appkit-utils Patch
@reown/appkit-common Patch
@reown/appkit-adapter-ethers Patch
@reown/appkit-adapter-ethers5 Patch
@reown/appkit-adapter-solana Patch
@reown/appkit-adapter-wagmi Patch
@reown/appkit Patch
@reown/appkit-cdn Patch
@reown/appkit-cli Patch
@reown/appkit-controllers Patch
@reown/appkit-core Patch
@reown/appkit-experimental Patch
@reown/appkit-polyfills Patch
@reown/appkit-scaffold-ui Patch
@reown/appkit-siwe Patch
@reown/appkit-siwx Patch
@reown/appkit-ui Patch
@reown/appkit-wallet Patch
@reown/appkit-wallet-button Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
appkit-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:36am
appkit-laboratory ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 8:36am
12 Skipped Deployments
Name Status Preview Comments Updated (UTC)
appkit-basic-ep ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-basic-ep-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-basic-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-basic-sign-client-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-basic-up-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-ethers5-bera ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-nansen-demo ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-vue-solana ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
appkit-wagmi-cdn-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
ethereum-provider-wagmi-example ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 8:36am
next-wagmi-solana-bitcoin-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am
vue-wagmi-example ⬜️ Ignored (Inspect) Apr 1, 2025 8:36am

@magiziz magiziz changed the title feat: bitget wallet connector for bitcoin feat: bitget wallet connector (bitcoin) Mar 31, 2025
Copy link
Contributor

github-actions bot commented Mar 31, 2025

Warnings
⚠️ File packages/adapters/bitcoin/src/adapter.ts contains a KEY or SECRET
⚠️ File packages/adapters/bitcoin/tests/BitcoinAdapter.test.ts contains a KEY or SECRET
⚠️ File packages/adapters/bitcoin/src/connectors/BitgetConnector.ts contains a KEY or SECRET
⚠️ File packages/adapters/bitcoin/tests/connectors/BitgetConnector.test.ts contains a KEY or SECRET
⚠️ File packages/adapters/bitcoin/src/connectors/BitgetConnector.ts contains a KEY or SECRET
⚠️ File packages/adapters/bitcoin/tests/connectors/BitgetConnector.test.ts contains a KEY or SECRET

Generated by 🚫 dangerJS against 7cde32a

Copy link
Contributor

github-actions bot commented Mar 31, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.05% 25011 / 33322
🔵 Statements 75.05% 25011 / 33322
🔵 Functions 66.32% 2117 / 3192
🔵 Branches 83.11% 4799 / 5774
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/adapters/bitcoin/src/adapter.ts 97% 95.23% 89.65% 97% 187-188, 200-201, 306-309
packages/adapters/bitcoin/src/connectors/BitgetConnector.ts 98% 96.55% 100% 98% 46-47
packages/appkit-utils/src/PresetsUtil.ts 100% 100% 100% 100%
packages/common/src/utils/ConstantsUtil.ts 100% 100% 100% 100%
Generated in workflow #10571 for commit 7cde32a by the Vitest Coverage Report Action

@arein arein requested a review from Copilot March 31, 2025 14:32
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Bitget wallet connector for Bitcoin, integrating it into the appkit and updating associated tests.

  • Added BITGET constant in ConstantsUtil
  • Configured BitgetConnector in PresetsUtil and integrated it into the BitcoinAdapter
  • Introduced BitgetConnector tests to validate functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/common/src/utils/ConstantsUtil.ts Added BITGET constant to support the new connector
packages/appkit-utils/src/PresetsUtil.ts Added BITGET preset mapping
packages/adapters/bitcoin/tests/connectors/BitgetConnector.test.ts New tests for the BitgetConnector
packages/adapters/bitcoin/tests/BitcoinAdapter.test.ts Updated tests to include BitgetConnector integration
packages/adapters/bitcoin/src/connectors/BitgetConnector.ts Introduced BitgetConnector implementation and event binding logic
packages/adapters/bitcoin/src/adapter.ts Updated adapter to instantiate and add the BitgetConnector

const wallet = bitkeep?.unisat

/**
* Bitget doesn't provide a way to get the image URL specifally for bitcoin
Copy link
Preview

Copilot AI Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the typo in the comment: replace 'specifally' with 'specifically'.

Suggested change
* Bitget doesn't provide a way to get the image URL specifally for bitcoin
* Bitget doesn't provide a way to get the image URL specifically for bitcoin

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant