chore: improve social login latency #4107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 641ae1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
|
…pkit into feat/improve-social-latency
There was a problem hiding this comment.
Pull Request Overview
This PR improves social login latency by reducing redundant calls and updating connection logic to support a new socialUri parameter. The changes update various adapter connectors and their clients to conditionally pass along the socialUri parameter for improved social login flow.
- Added socialUri parameter to connection methods in wagmi, solana, ethers, and bitcoin adapters.
- Updated CHANGELOGs and changeset entries to document test versions for social login improvements.
Reviewed Changes
Copilot reviewed 52 out of 59 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/appkit-utils/CHANGELOG.md | Updated changelog with a test version and dependency updates |
| packages/adapters/wagmi/src/connectors/AuthConnector.ts | Added socialUri support in the connect method |
| packages/adapters/wagmi/src/client.ts | Updated connection parameters to pass socialUri with a TS override |
| packages/adapters/wagmi/CHANGELOG.md | Updated changelog documentation for wagmi adapter |
| packages/adapters/solana/src/providers/AuthProvider.ts | Added socialUri option to the connect call |
| packages/adapters/solana/src/client.ts | Updated connection parameters to pass socialUri |
| packages/adapters/solana/CHANGELOG.md | Updated changelog documentation for solana adapter |
| packages/adapters/ethers5/src/client.ts | Added socialUri parameter in the ethers5 adapter connect method |
| packages/adapters/ethers5/CHANGELOG.md | Updated changelog documentation for ethers5 adapter |
| packages/adapters/ethers/src/client.ts | Added socialUri parameter in the ethers adapter connect method |
| packages/adapters/ethers/CHANGELOG.md | Updated changelog documentation for ethers adapter |
| packages/adapters/bitcoin/CHANGELOG.md | Updated changelog documentation for bitcoin adapter |
| .changeset/modern-eyes-smash.md | Added changeset entry to include social login improvements test version |
Files not reviewed (7)
- .changeset/pre.json: Language not supported
- packages/adapters/bitcoin/package.json: Language not supported
- packages/adapters/ethers/package.json: Language not supported
- packages/adapters/ethers5/package.json: Language not supported
- packages/adapters/solana/package.json: Language not supported
- packages/adapters/wagmi/package.json: Language not supported
- packages/appkit-utils/package.json: Language not supported
| @@ -523,7 +523,9 @@ export class WagmiAdapter extends AdapterBlueprint { | |||
|
|
|||
| const res = await connect(this.wagmiConfig, { | |||
| connector, | |||
| chainId: chainId ? Number(chainId) : undefined | |||
| chainId: chainId ? Number(chainId) : undefined, | |||
| // @ts-expect-error socialUri is needed for auth connector but not in wagmi types | |||
There was a problem hiding this comment.
Consider updating the wagmi connector type definitions to include the 'socialUri' parameter rather than suppressing the TypeScript error.
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed an abundant call to magic, so we improve the social login latency. I’ve made some changes to the logic for how we connect with the
w3mFrameProvider. Within the connect call, we can now either make a request to Magic to retrieve the user or initiate a social login. These changes also require updates to the schema on the secure site.Type of change
Associated Issues
For Linear issues: Closes APKT-xxx
For GH issues: closes #...
Showcase (Optional)
If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.
Checklist