-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix: swap screen freezes when swap allowance fails #4102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
12 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 4d0c1e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SwapController.swapTokens() | ||
|
||
return | ||
await SwapController.swapTokens() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there was a fetch error we did an early return and it never redirected to SwapPreview
screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌🏽
Coverage Report
File Coverage
|
Description
Fixed an issue where the swap screen froze if allowance approval failed
Type of change
Associated Issues
For Linear issues: Closes APKT-2225
Showcase (Optional)
Before:
before.mov
After:
after.mov
Checklist