added conda virtual env name to prompt

[GPSBach]

Currently, conda doesn't set the $VIRTUAL_ENV variable when activating an environment, instead storing the same information under $CONDA_PREFIX. Added this to the script so that the names of conda environments will be displayed.

Note: the order of the if/elif statement means that $VIRTUAL_ENV will supercede $CONDA_PREFIX if both exist...I am not sure if or when this happens e.g. activating a virtualenv environment from within a conda environment. Because there are so many environment managers, i haven't checked the interplay between each and conda.

[reobin]

Hi @GPSBach !

Thanks for the PR!

Since both are used in python environments, I think the behavior you chose makes the most sense.

[GPSBach]

As far as testing goes, do you have a framework in mind or should I just muck around and test on my own computer?

[reobin]

No automatic tests exist at the moment, but it’s definitely I want to try to do one day. Pretty challenging stuff testing a prompt, but definitely doable.

Once it’s up to date, I’ll play around with virtual env on my side to make sure it works great. If you have the same results
on your side with conda, I‘ll consider the feature ready. No extensive testing is needed here

[GPSBach]

FYI its working well on my end with both conda and pipenv (BTW OSX Catalina)

…

On Wed, Sep 23, 2020 at 12:51 PM Robin Gagnon ***@***.***> wrote: No automatic tests exist at the moment, but it’s definitely I want to try to do one day. Pretty challenging stuff testing a prompt, but definitely doable. Once it’s up to date, I’ll play around with virtual env on my side to make sure it works great. If you have the same results on your side with conda, I‘ll consider the feature ready. No extensive testing is needed here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIMYP2EHO7ITQYKOR47FYGDSHIYR7ANCNFSM4RXGOTIQ> .

[reobin]

Working well on my end too!

Thank you @GPSBach !

[reobin]

@all-contributors please add @GPSBach for code and ideas

[allcontributors]

@reobin

I've put up a pull request to add @GPSBach! 🎉