Skip to content

fix(presets): apply NodeJS docker workaround for private registries #32220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

secustor
Copy link
Collaborator

Changes

Changes NodeJS docker image workaround to match any docker image too which ends on /node

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor secustor requested a review from viceice October 30, 2024 13:12
@secustor secustor enabled auto-merge October 30, 2024 13:12
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there is a docker image we need to exclude because it's not nodejs. 🤔

@secustor secustor requested a review from viceice October 30, 2024 14:16
@secustor secustor added this pull request to the merge queue Oct 30, 2024
Merged via the queue into renovatebot:main with commit 9faae86 Oct 30, 2024
39 checks passed
@secustor secustor deleted the fix/nodejs-workaround-for-internal-registry branch October 30, 2024 14:46
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 38.138.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants