Skip to content

feat(versioning): isBreaking #31859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 9, 2025
Merged

feat(versioning): isBreaking #31859

merged 19 commits into from
May 9, 2025

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Oct 8, 2024

Changes

Adds new concept isBreaking

TODO:

  • docs, including matchJsonata example
  • branch.isBreaking logic
  • Cargo versioning
  • Decide on unstable
  • Handle python minor=breaking out of the box somehow?

Context

Should be ready to be used with matchJsonata as an alternative to matchUpdateTypes=major.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as draft October 10, 2024 12:00
@rarkins rarkins marked this pull request as ready for review April 24, 2025 18:57
@rarkins rarkins marked this pull request as draft April 24, 2025 18:58
@rarkins rarkins marked this pull request as ready for review April 24, 2025 19:48
@rarkins rarkins requested review from viceice and secustor April 24, 2025 19:59
secustor
secustor previously approved these changes Apr 26, 2025
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should add docs what the functions are for on versioning. Just like we have for managers.

@rarkins rarkins requested review from viceice and secustor April 28, 2025 07:39
viceice
viceice previously approved these changes Apr 28, 2025
secustor
secustor previously approved these changes Apr 30, 2025
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some docs improvements. 😉

viceice
viceice previously approved these changes May 4, 2025
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would love to include the docs improvements

@rarkins rarkins dismissed stale reviews from viceice and secustor via 3380987 May 9, 2025 05:56
@rarkins rarkins requested review from viceice and secustor May 9, 2025 05:56
@rarkins rarkins enabled auto-merge May 9, 2025 05:57
@rarkins rarkins added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 6793550 May 9, 2025
40 checks passed
@rarkins rarkins deleted the feat/24513-is-breaking branch May 9, 2025 08:24
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 40.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

RGunning pushed a commit to RGunning/renovate that referenced this pull request May 25, 2025
Co-authored-by: HonkingGoose <[email protected]>
Co-authored-by: Michael Kriese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add first class support for breaking/non-breaking concept
5 participants