Skip to content

Laravel 10.x Compatibility #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 1, 2023

Conversation

laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l10-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.5.10. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-aws-webhooks.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "renoki-co/laravel-aws-webhooks": "dev-l10-compatibility",
    }
}

Finally, run: composer update

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.96 🎉

Comparison is base (b3d1e1f) 93.33% compared to head (1d463a9) 96.29%.

❗ Current head 1d463a9 differs from pull request most recent head 38adf1a. Consider uploading reports for the commit 38adf1a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     93.33%   96.29%   +2.96%     
  Complexity       11       11              
============================================
  Files             4        4              
  Lines            30       27       -3     
============================================
- Hits             28       26       -2     
+ Misses            2        1       -1     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fransjooste1
Copy link

Any chance this can be merged in?

@lieto-dk
Copy link

Would be great to have laravel 10 support (as we are looking to update, but only outstanding issue is your package ..)

@stefanzweifel
Copy link
Contributor

@rennokki Would you be able to merge this PR and tag a new version? The Shift-fork works great in the dev-environment of my Laravel 10 app.

Thanks you so much. 🙌

@rennokki rennokki merged commit 0e806ad into renoki-co:master Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants