[fix] Add check for eventType or notificationType in AWS SES handler #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to use this package and during testing I saw that AWS sends notifications but I had problems with registering response in application. I was testing with AWS [email protected] and [email protected] addresses.
After some debugging I figured out that problem is in response. This package check for $decodedMessage['eventType'] but in my response from AWS there is no eventType key, but instead I had notificationType.
Response is basically same only difference is in object key name ( eventType -> notificationType ).
I fixed this in my project by overriding onNotification method and adding check for type and everything else works as expected.
Here you can read more about this issue - mautic/mautic#8903 (comment)