fix(dev): don't use "module" server conditions in Vitest

[remorses]

Fix #13869

[changeset-bot]

🦋 Changeset detected

Latest commit: 86c6173

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@react-router/dev	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch
react-router	Patch
react-router-dom	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @remorses,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[remorses]

Another solution would be to only add the "node" condition and do not use the defaultServerConditions variable

The default Vite ssr config does not seem to use defaultServerConditions: https://github.com/vitejs/vite/blob/ec067671d019023109f974310a9cd974a4091251/packages/vite/src/node/ssr/runnerImport.ts#L36

[Andarist]

@remorses I see we have opened somewhat similar PRs at almost the same time. Mine can be seen here: #13871 . Note that the fallout of misapplying those conditions is bigger and not unique to Vitest - my PR addresses the whole problem by "reusing" the correct defaults.

EDIT:// Actually, I might have jumped the gun here. You'd have to check if my PR solves your Vitest problem because it might not - it depends on the actual root cause of that problem. It might overlap with mine but maybe it doesn't.

[remorses]

Hey, I already tried your PR but it did not fix the issue, module needs to be removed from the conditions field too

[remorses]

This PR fixes a problem that already 106 people had to debug and find by themselves (which takes a lot of time)

https://github.com/search?q=%21process.env.VITEST+%26%26+reactRouter%28%29%2C+path%3Avite.config*&type=code