Support triggable references (branches, tags). Ignore triggable references on GitHub action #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow GitHub Action and GitHub app which allows us to work with any reference See https://developer.github.com/v4/object/repository/#ref
GitHub is fair game since they have a better syntax for when to run See https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#on
This change is actually backwards compatible thanks to Joi
jetersen
commented
Jun 1, 2020
This was referenced Jun 1, 2020
This was referenced Jun 1, 2020
|
@darkdreamingdan would you mind reviewing this PR 🙏 |
|
This is great. These changes would allow this action to work in a git flow context. Thanks for submitting this PR. I will patiently wait for a merge :) |
IncPlusPlus
added a commit
to IncPlusPlus/titanfall2-rp
that referenced
this pull request
Oct 7, 2021
Per release-drafter/release-drafter#546, this is now called "references" and only used in the GitHub app version.
This was referenced Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While exploring this issue I found many issues that this PR will greatly improve the experience for.
ref/tagswhen running on GitHub appcc @toolmantim @TimonVS
There should be minimal impact as seen in the test changes we support both
branchesandreferencesdefinition.@arminc this should fully unlock any GitHub workflow you desire.
Note to self: Release notes should make clear
branchesis renamed toreferencesfixes #550
fixes #545
fixes #515
fixes #542
fixes #527
fixes #520
fixes #404
fixes #203
fixes #141