Skip to content

feat(reg-notify-github-plugin): support short description #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

mj-hd
Copy link
Contributor

@mj-hd mj-hd commented Feb 19, 2022

What does this change?

I've ported the reg-notify-github-with-api-plugin's shortDescription option to reg-notify-github-plugin.

Some checks will fail because reg-gh-app-inteface is not published yet. (I've confirmed these checks by overriding the dependency to my forked repository.)

References

Screenshots

  • without shortDescription

SCR-20220219-f76

  • with shortDescription

SCR-20220219-fuv

What can I check for bug fixes?

@mj-hd mj-hd changed the title feat(reg-notify-github-plugin): support short desc feat(reg-notify-github-plugin): support short description Feb 19, 2022
@mj-hd
Copy link
Contributor Author

mj-hd commented Apr 10, 2022

@Quramy Please let me know after reg-gh-app-interface v1.3.2 is published. I will update the deps to correct type checking error.
This PR needs the type changes by reg-viz/gh-app#60.

@lcdsmao
Copy link

lcdsmao commented Jun 3, 2022

@Quramy
Do you have any time to please take a look at this? 🙏

@Quramy Quramy merged commit 0ee5da1 into reg-viz:master Jun 8, 2022
@Quramy
Copy link
Member

Quramy commented Jun 8, 2022

@mj-hd @lcdsmao

Sorry for my late reply 🙇 I've published at this issue as v0.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create a limit to show 🔵 emoji to bot comment
3 participants