Fix radio button null element default prop to use correct input #10510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @jason-curtis |
|
Understood. Let's see if I get to the tests before a maintainer does! |
|
Holy cow I can't believe this has been in here like this for so long without someone noticing! Thanks for this fix @jason-curtis! |
thedavidprice
added
the
contributor-pr
|
Hey @jason-curtis, I'm aiming to try get this one in sometime this week. If you want to add tests to it then I can hold off but otherwise I'll get to it in the next couple days. |
|
Go ahead. Thank you for checking! My current project has progressed past
using the scaffolding heavily so I can’t prioritize it right now.
Iirc, I think I was having problems using the null state on these controls.
Make sure to check that you can actually submit a null value from the front
end.
<https://optionzero.co>
…On Wed, May 8, 2024 at 12:03 AM Josh GM Walker ***@***.***> wrote:
Hey @jason-curtis <https://github.com/jason-curtis>, I'm aiming to try
get this one in sometime this week. If you want to add tests to it then I
can hold off but otherwise I'll get to it in the next couple days.
—
Reply to this email directly, view it on GitHub
<#10510 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZPVUYNZXSUVA65LBIUF2LZBHE4JAVCNFSM6AAAAABGXNR3U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZHA4DGMJRG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Josh-Walker-GM
approved these changes
May 8, 2024
Josh-Walker-GM
added a commit
that referenced
this pull request
May 8, 2024
Previously, radio buttons always had the first element that referred to
`props.spot.spotType`:
```
<RadioField
id=...
name=...
defaultValue=...
defaultChecked={!props.spot?.spotType}
className="rw-input"
errorClassName="rw-input rw-input-error"
/>
```
In actuality, instead of "spot" and "spotType" we should be using the
actual name of the model and column!
---------
Co-authored-by: Josh GM Walker <[email protected]>
Josh-Walker-GM
added a commit
that referenced
this pull request
May 15, 2024
Previously, radio buttons always had the first element that referred to
`props.spot.spotType`:
```
<RadioField
id=...
name=...
defaultValue=...
defaultChecked={!props.spot?.spotType}
className="rw-input"
errorClassName="rw-input rw-input-error"
/>
```
In actuality, instead of "spot" and "spotType" we should be using the
actual name of the model and column!
---------
Co-authored-by: Josh GM Walker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, radio buttons always had the first element that referred to
props.spot.spotType:In actuality, instead of "spot" and "spotType" we should be using the actual name of the model and column!