-
Notifications
You must be signed in to change notification settings - Fork 1k
[Bug?]: dbAuth handler resePasword does not validate password format as signup does #10724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello @irg1008 thanks for raising this, and I can confirm that you cannot currenly customise the validation function on the server side for reset password. @cannikin I looked through the dbAuth handler, and it would be relatively straightforward (I think!) to call the options - If you have time, do you think you could look at this one please? |
I think I can do this no problem |
Okay I just created de PR. Check it out if you find the time. Could this mean breaking changes since could affect some users bussiness logic? |
…10734) Related to #10724. This pull request adds password validation on resetPassword handler using the one from the signup handler. This could affect some users that "expect" no validation from this handler and some new errors and failed tests may be raised for them, but I think this feature is primary concerning security and to mantain validation logic between handlers --------- Co-authored-by: Rob Cameron <[email protected]>
This was closed by #10734 or is there more work to be done on this? |
…10734) Related to #10724. This pull request adds password validation on resetPassword handler using the one from the signup handler. This could affect some users that "expect" no validation from this handler and some new errors and failed tests may be raised for them, but I think this feature is primary concerning security and to mantain validation logic between handlers --------- Co-authored-by: Rob Cameron <[email protected]>
What's not working?
dbAuth handler resePasword does not validate password format as signup does
Basically on signUp handler we can set a custom password validation like for exmaple:
But then in the "resetPassword" handler the password is set to the database as it comes from the client, be that a simple number....
We should be able to validate the password somehow, maybe using the same passwordValidation as sign up since that makes sense
How do we reproduce the bug?
No response
What's your environment? (If it applies)
No response
Are you interested in working on this?
The text was updated successfully, but these errors were encountered: