iceberg/rest_client: catch exception in retry() attempt #25273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously saw error logs when perfoming Iceberg snapshot removal around shutdown: ``` WARN 2025-03-06 16:50:15,657 [shard 1:main] http - [/iceberg/v1/main/namespaces/redpanda/tables/test~dlq] - client.cc:143 - make_request timed-out connection attempt /iceberg/v1/main/namespaces/redpanda/tables/test~dlq WARN 2025-03-06 16:50:15,657 [shard 1:main] iceberg - rest_catalog.cc:62 - error returned when executing load_table - http_call_error: Exception during retry sleep: seastar::sleep_aborted (Sleep is aborted) ERROR 2025-03-06 16:50:15,657 [shard 1:main] datalake - coordinator.cc:125 - Coordinator hit exception while running in term 1: seastar::abort_requested_exception (abort requested) ``` The issue is that the retry_chain_node::retry call checks the abort source. This commit wraps this call with a catch to return an appropriate non-exceptional error type. Without this, datalake/schema_evolution_test.py was very flaky. With this change it at least appears to run fine locally.
oleiman
approved these changes
Mar 6, 2025
Yea this seems likely considering how many there are, plus parameterization |
CI test resultstest results on build#62752
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously saw error logs when perfoming Iceberg snapshot removal around shutdown:
The issue is that the retry_chain_node::retry call checks the abort source. This commit wraps this call with a catch to return an appropriate non-exceptional error type.
Without this, datalake/schema_evolution_test.py was very flaky. With this change it at least appears to run fine locally.
Backports Required
Release Notes