Add custom connection validation to ConnectionPoolSupport #3081

[big-cir]

Overview

• Introduce Predicate for connection validation
• Add new overload to ConnectionPoolSupport.createGenericObjectPool()
• Implement ConnectionPoolConfig to encapsulate validation and wrapping options
• Update RedisPooledObjectFactory to use custom validation logic

Closes #3081

[tishun]

Hey @big-cir ,

did you try running mvn formatter:format?

[big-cir]

@tishun
thanks :)
I tried running mvn formatter:format.

[tishun]

Addressed a few things:

• make sure we preserve the existing API contract by only extending it
• no need for an additional ObjectFactory
• (just in case) added the option for createSoftReferenceObjectPool too
• added new unit tests, reverted the existing ones, to make sure we preserve the contract

[tishun]

Thank you for the contribution!

[big-cir]

Thank you for the detailed explanation of the changes.
I'm sorry i'm not able to help, but I'll try to do so in future contributions. :)

[tishun]

Thank you for the detailed explanation of the changes. We're sorry we weren't able to help, but we'll try to do so in future contributions. :)

On the contrary, you helped a lot, you did most of the work! :)

It's sometimes faster and easier to do the final polishing myself.

[big-cir]

Thank you so much for your kind words!

I appreciate your support and guidance throughout the process.

I'll keep doing my best in future contributions!🙇‍♂️