Skip to content

StreamReadOutput in Lettuce 6 creates body entries containing the stream id #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mp911de opened this issue Feb 5, 2020 · 1 comment
Closed

StreamReadOutput in Lettuce 6 creates body entries containing the stream id #1216

mp911de opened this issue Feb 5, 2020 · 1 comment
Labels
type: blocker An issue that is blocking us from releasing type: bug A general bug
Milestone
6.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Feb 5, 2020 •
edited
Loading

Calling XREAD on Redis 5 returns the stream Id within StreamMessage.getBody()
@mp911de mp911de added type: bug A general bug type: blocker An issue that is blocking us from releasing labels Feb 5, 2020
@mp911de mp911de added this to the 6.0 M1 milestone Feb 5, 2020
@mp911de
Copy link
Collaborator Author

mp911de commented Feb 6, 2020

In Lettuce 6, the stream Id parsing and multi notifications work slightly different and that is why the message id slipped into the message body.

mp911de added a commit that referenced this issue Feb 6, 2020
@mp911de
Fix StreamMessage parsing for XREAD #1216
f140277 
StreamReadOutput now correctly retains the stream key after parsing a StreamMessage.
@mp911de mp911de closed this as completed Feb 6, 2020
mp911de added a commit that referenced this issue Feb 10, 2020
@mp911de
Fix StreamMessage parsing for XREAD #1216
f73b810 
StreamReadOutput now correctly retains the stream key after parsing a StreamMessage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: blocker An issue that is blocking us from releasing type: bug A general bug
Projects
None yet
Milestone
6.0 M1
Development

No branches or pull requests
1 participant
@mp911de