Skip to content

[ISV-5618] Fix check_upgrade_graph_loop for community operators #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

mporrato
Copy link
Contributor

@mporrato mporrato commented Feb 17, 2025

  • Update the static test to use proper dfs cycle detection to avoid performance issues leading to timeouts with operators using skipRange
  • Convert the static check into an Operator static check (as opposed to a Bundle static check) as it involves parsing multiple bundles
  • Fix log messages emitted by the skip_fbc decorator

This change was tested against all the community operators and no performance issues were found; however, the following operators fail the check because of issues with metadata (either the replaces field being set to an empty string or invalid skipRange definitions):

  • enc-key-sync
  • hedvig-operator
  • logging-operator
  • mongodb-operator
  • oadp-operator
  • odoo-operator
  • openshift-nfd-operator
  • rabbitmq-single-active-consumer-operator
  • special-resource-operator

None of those operators have received updates in the last 1.5 years.

Merge Request Checklists

  • Development is done in feature branches
  • Code changes are submitted as pull request into a primary branch [Provide reason for non-primary branch submissions]
  • Code changes are covered with unit and integration tests.
  • Code passes all automated code tests:
    • Linting
    • Code formatter - Black
    • Security scanners
    • Unit tests
    • Integration tests
  • Code is reviewed by at least 1 team member
  • Pull request is tagged with "risk/good-to-go" label for minor changes

- Update the static test to use proper bfs cycle detection to avoid
  performance issues leading to timeouts with operators using skipRange
- Convert the static check into an Operator static check (as opposed to
  a Bundle static check) as it involves parsing multiple bundles
- Fix log messages emitted by the skip_fbc decorator

Signed-off-by: Maurizio Porrato <[email protected]>
@tomasbakk
Copy link
Contributor

LGTM

Signed-off-by: Maurizio Porrato <[email protected]>
@mporrato mporrato merged commit 39dc9a6 into main Feb 19, 2025
3 checks passed
@mporrato mporrato deleted the ISV-5618 branch February 19, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants