Semantic highlighting sometimes looks bad

[fbricon]

When "java.semanticHighlighting.enabled": true, even without any particular token settings, this causes bad highlighting of existing code using static imports:
When enabled:

When disabled:

[rafaelrenanpacheco]

Isn't this a specific color theme bug? I'm using this beautiful theme and the semantic highlight for fields inside methods are working as expected:

Before semantic token it was not possible to set the fields color inside a method. Only fields with this. prefix got coloring.

[Eskibear]

The bug is caused by caclulating semantic tokens of wrong AST nodes. And it should be fixed by eclipse-jdtls/eclipse.jdt.ls#1412 and eclipse-jdtls/eclipse.jdt.ls#1418 .

Below are steps to stably reproduce it.

• Open an empty folder.
• Create 2 .java files (A.java, B.java) directly under the folder.
• Open A.java and close all the other files.
• Do some editing in A.java, e.g. type some whitespaces
• Now open B.java, you'll see wired highlighting.

A.java

public class A {
    String aString = "";
}

B.java

public class B {
    final static int constantInteger = 1;
}

[fbricon]

Fixed in 0.61.0

[JoeyRxy]

Hi, I think this problem didn't solved, I've encountered this situation in 0.66.0 version!

[Eskibear]

@JoeyRxy Can you figure out a way to stably reproduce it? That would be a great help for us to understand the cause and provide a fix.

[JoeyRxy]

@JoeyRxy Can you figure out a way to stably reproduce it? That would be a great help for us to understand the cause and provide a fix.

I think this problem occurs randomly. When you open a java file in a project (maven project most time in my situation), sometimes this problem occurs after you edit something.

in the pictures above, I just input an Enter, then it was broken, until reopening the file or do more editing. I think that's because those action trigger the refreshing or re-rendering action.

issue-in-vscode

[0dinD]

@Eskibear I'm pretty sure this is related to #1597, and I don't think it's caused by any of my changes since I've seen it happen occasionally before, in version 0.64 or earlier. I've tried to reproduce it, but it was hard to find any consistent way to do it. See my comment for what I've been able to find out so far. I'll try to find some steps to reproduce it if I have time next week.

[lucsoft]

Semantic highlighting often still goes bad when doing larger refactors in larger files (500 LoC)

Can't really show code. But i can tell that its a maven eclipse mono repo project with java 17, java module system.

Often saving or adding a new line fixes it

[0dinD]

@lucsoft It turns out that there is a different issue which can still cause the semantic tokens to become desynced (this is probably what you've run into). This is being tracked by #2176.