Skip to content

adding acs workspace for backstage 1.35.1 on branch release-1.5 #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release-1.5
Choose a base branch
from

Conversation

maknop
Copy link

@maknop maknop commented Mar 28, 2025

This PR adds the acs workspace so that an OCI artifact can be created from the plugin located at github.com/backstage/community-plugins/plugins/acs. The purpose of this is to install the ACS plugin in RHDH instances.

@davidfestal
Copy link
Member

/publish

Copy link

Publish workflow has completed with failure.

@davidfestal
Copy link
Member

/publish

Copy link

Publish workflow has completed with success.

@davidfestal
Copy link
Member

/publish

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.2

Co-authored-by: David Festal <[email protected]>
@maknop
Copy link
Author

maknop commented Mar 31, 2025

Just fixed, thanks!

@davidfestal
Copy link
Member

You should be able to test it inside RHDH by adding this line in the dynamic plugins configuration:

  - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.2!backstage-community-plugin-acs
    pluginConfig:
      <your frontend plugin wiring configuration>

@davidfestal
Copy link
Member

/publish

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.2

@davidfestal davidfestal added the help wanted to test Help wanted to test the generated OCI images inside RhDH label Apr 1, 2025
@davidfestal
Copy link
Member

@maknop Please notify here when you have validated, through testing inside RHDH 1.5, that this OCI image works.
Then we would update the label to tested and would be ready to merge this branch, and have the final OCI image (without the PR number in the tag) published.

@davidfestal
Copy link
Member

cc @BethGriggs

@davidfestal
Copy link
Member

@maknop Can you confirm that the PRs correctly work, and that the PR can be merged and the images be published and be usable in RHDH 1.5 ?

@maknop
Copy link
Author

maknop commented Apr 23, 2025

Hi @davidfestal! Sorry, I just saw your message. I just pushed up another update to the image tag. When I deployed the OCI image in our RHDH instance it worked but had a few bugs that I wanted to resolve. Should be good now 👍

@maknop
Copy link
Author

maknop commented Apr 23, 2025

I'd like to test this again though once this new commit lands.

@maknop
Copy link
Author

maknop commented Apr 24, 2025

/publish

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.4

@davidfestal
Copy link
Member

/publish

Copy link

Publish workflow has completed with failure.

@davidfestal
Copy link
Member

/publish

Copy link

The versions.json file in your PR doesn't match the one in release branch #release-1.5
Try updating it by adding the /update PR comment.

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.4

@davidfestal
Copy link
Member

/update

2 similar comments
@davidfestal
Copy link
Member

/update

@davidfestal
Copy link
Member

/update

Copy link

The file versions.json could not be synced from branch release-1.5 into this because your PR is from a fork.

You should update the versions.json file with the following content:

{
    "backstage": "1.35.1",
    "node": "20.18.x",
    "cli": "3.4.2"
}

@davidfestal
Copy link
Member

/publish

Copy link

The versions.json file in your PR doesn't match the one in release branch #release-1.5
Try updating it by adding the /update PR comment.

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.4

Copy link

The file versions.json could not be synced from branch release-1.5 into this because your PR is from a fork.

You should update the versions.json file with the following content:

{
    "backstage": "1.35.1",
    "node": "20.18.x",
    "cli": "3.4.2"
}

1 similar comment
Copy link

The file versions.json could not be synced from branch release-1.5 into this because your PR is from a fork.

You should update the versions.json file with the following content:

{
    "backstage": "1.35.1",
    "node": "20.18.x",
    "cli": "3.4.2"
}

@davidfestal davidfestal removed the help wanted to test Help wanted to test the generated OCI images inside RhDH label Apr 29, 2025
@maknop
Copy link
Author

maknop commented Apr 30, 2025

/publish

Copy link

Publish workflow has completed with success.

  • Published container images:
    • ghcr.io/redhat-developer/rhdh-plugin-export-overlays/backstage-community-plugin-acs:pr_986__0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants