fix: change machine stream close function context #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sonia Sandler <[email protected]>
benoitf
approved these changes
Jun 26, 2025
feloy
approved these changes
Jun 27, 2025
cdrage
added a commit
to cdrage/podman-desktop-extension-bootc
that referenced
this pull request
Jun 27, 2025
### What does this PR do? See: redhat-developer/podman-desktop-rhel-ext#194 With the new changes coming to Podman Desktop for the fix, this also needs to be added too. Copying / pasting this into our `macadam-machine-stream.ts` to propagate the change. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Part of redhat-developer/podman-desktop-rhel-ext#81 ### How to test this PR? <!-- Please explain steps to reproduce --> N/A, have to wait for PD changes to propagate: PR's: - podman-desktop/podman-desktop#12982 - podman-desktop/podman-desktop#12981 Signed-off-by: Charlie Drage <[email protected]>
cdrage
added a commit
to cdrage/podman-desktop-extension-bootc
that referenced
this pull request
Jun 27, 2025
### What does this PR do? See: redhat-developer/podman-desktop-rhel-ext#194 With the new changes coming to Podman Desktop for the fix, this also needs to be added too. Copying / pasting this into our `macadam-machine-stream.ts` to propagate the change. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Part of redhat-developer/podman-desktop-rhel-ext#81 ### How to test this PR? <!-- Please explain steps to reproduce --> N/A, have to wait for PD changes to propagate: PR's: - podman-desktop/podman-desktop#12982 - podman-desktop/podman-desktop#12981 Signed-off-by: Charlie Drage <[email protected]>
cdrage
added a commit
to podman-desktop/extension-bootc
that referenced
this pull request
Jun 27, 2025
### What does this PR do? See: redhat-developer/podman-desktop-rhel-ext#194 With the new changes coming to Podman Desktop for the fix, this also needs to be added too. Copying / pasting this into our `macadam-machine-stream.ts` to propagate the change. ### Screenshot / video of UI <!-- If this PR is changing UI, please include screenshots or screencasts showing the difference --> N/A ### What issues does this PR fix or reference? <!-- Include any related issues from Podman Desktop repository (or from another issue tracker). --> Part of redhat-developer/podman-desktop-rhel-ext#81 ### How to test this PR? <!-- Please explain steps to reproduce --> N/A, have to wait for PD changes to propagate: PR's: - podman-desktop/podman-desktop#12982 - podman-desktop/podman-desktop#12981 Signed-off-by: Charlie Drage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without binding the
closefunction tothis, any calling forclosewill output an error saying thatthis.closeStream()(L#82) is not a function due to the different calling context ofcloseRelated to #81