Skip to content

Tutorial updated to latest version of kn #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Tutorial updated to latest version of kn #285

merged 5 commits into from
Feb 1, 2022

Conversation

ammbra
Copy link
Contributor

@ammbra ammbra commented Jan 31, 2022

No description provided.

Copy link
Contributor

@sebastienblanc sebastienblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive PR ! Good stuff !
One thing we need to check (after merging this one) is to get rid of the hardcoded namespace so that we can use this tutorial for the sandbox as well.

@ammbra ammbra merged commit 2a67108 into master Feb 1, 2022
github-actions bot pushed a commit that referenced this pull request Feb 1, 2022
* refactoring tutorial to work with newer version of Knative

* reverted change related to gulpfile.ts

* final changes

* staging.yml updated as well.

* Resolved comments from Sebastien.

Co-authored-by: ammbra <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>
@ammbra ammbra linked an issue Feb 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script install-istio.sh doesn't work for minikube 1.23.2
3 participants