Skip to content

Add initial design proposal for nextgen applier, Dash #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2019

Conversation

etsauer
Copy link
Contributor

@etsauer etsauer commented Jul 31, 2019

What does this PR do?

We had our first design session around the next major iteration of applier. Here's a proposal doc resulting from that meeting. It will be a living document for some time, so we're not expecting this PR to be perfect.

Who would you like to review this?

cc: @redhat-cop/openshift-applier


## Desired Feature List

- Dash should take the form of a CLI tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to mention anything about it being a library that can be consumed directly (in addition to the CLI option)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oybed done.

@tylerauerbeck
Copy link
Contributor

@etsauer So I like this as the start of the design proposal. I do have a few additional thoughts on what the inventory looks like though but not sure we want this to get stuck debating the inventory layout. Do we want to have these discussions elsewhere (a different PR, an issue, etc.) or are we okay having these held here prior to merge?

@oybed
Copy link
Contributor

oybed commented Jul 31, 2019

@tylerauerbeck IMHO I'd like to get this PR merged rather quickly and then accepting additional follow-up PRs. In that way, we can have a bit more focused conversations in the specific areas - instead of potentially holding up the entire write-up at first.

@etsauer
Copy link
Contributor Author

etsauer commented Jul 31, 2019

@tylerauerbeck I would say if you have specific thoughts on what I've written so far, feel free to comment up the doc. But let's not consider merging this PR as "proposal complete".

oybed
oybed previously approved these changes Jul 31, 2019
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit 18b0821 into redhat-cop:master Jul 31, 2019
@etsauer etsauer deleted the dash-proposal branch July 31, 2019 16:59
etsauer added a commit to etsauer/openshift-applier that referenced this pull request Jul 31, 2019
* Add initial design proposal for nextgen applier, Dash

* Update with intent to expose library

* Add golang as desired implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants