Skip to content

DFBUGS-1953 DFBUGS-1952: rebase: update golang.org/x/net to v0.33 to address CVE-2024-45338 #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nixpanic
Copy link
Member

update golang.org/x/net to v0.33 to address CVE-2024-45338

This is already part of the main and release-4.19 branches.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 31, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

update golang.org/x/net to v0.33 to address CVE-2024-45338

This is already part of the main and release-4.19 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@iPraveenParihar
Copy link
Member

@nixpanic, can we update golang.org/x/net to v0.36.0 to address https://issues.redhat.com/browse/DFBUGS-1953 which requires 'fixResolution': 'Upgrade to version v0.36.0' ?

@nixpanic
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member Author

nixpanic commented Apr 14, 2025

/retitle DFBUGS-1953 DFBUGS-1952: rebase: update golang.org/x/net to v0.33 to address CVE-2024-45338

The change in this PR addresses two DFBUGS.

@openshift-ci openshift-ci bot changed the title DFBUGS-1952: rebase: update golang.org/x/net to v0.33 to address CVE-2024-45338 DFBUGS-1953 DFBUGS-1952: rebase: update golang.org/x/net to v0.33 to address CVE-2024-45338 Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

update golang.org/x/net to v0.33 to address CVE-2024-45338

This is already part of the main and release-4.19 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member Author

/jira refresh

Not sure why it's not picking up the target release 😞

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is invalid:

  • expected the bug to target the "odf-4.18.2" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Not sure why it's not picking up the target release 😞

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@nixpanic
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting and removed jira/invalid-bug labels Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: This pull request references [Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 14, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@nixpanic: This pull request references [Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

This pull request references [Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18.2) matches configured target version for branch (odf-4.18.2)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Madhu-1
Copy link
Member

Madhu-1 commented Apr 14, 2025

/hold

@openshift-merge-bot openshift-merge-bot bot merged commit c153477 into red-hat-storage:release-4.18 Apr 14, 2025
12 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025

@nixpanic: [Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1953](https://issues.redhat.com//browse/DFBUGS-1953) has been moved to the MODIFIED state.

[Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1952](https://issues.redhat.com//browse/DFBUGS-1952) has been moved to the MODIFIED state.

In response to this:

update golang.org/x/net to v0.33 to address CVE-2024-45338

This is already part of the main and release-4.19 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants