-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to use array in controller
param in config
#906
Add support to use array in controller
param in config
#906
Conversation
@mfn I updated the Pull request. |
…troller-param-in-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can you please:
- work in my feedback
- add an example for array syntax in the config itself, .e. g
// The controller/method to use in GraphQL request. // Also supported array syntax: `[\Rebing\GraphQL\GraphQLController::class, 'query']` 'controller' => \Rebing\GraphQL\GraphQLController::class . '@query',
- resolve the conflicts with master?
After that, I'm happy to merge the PR!
README.md
Outdated
@@ -2655,7 +2655,7 @@ To prevent such scenarios, you can add the `UnusedVariablesMiddleware` to your | |||
The default makes the API available via `/graphql` | |||
- `controller`\ | |||
Allows overriding the default controller class, in case you want to extend or | |||
replace the existing one. | |||
replace the existing one. (also supports `array` format) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace the existing one. (also supports `array` format) | |
replace the existing one (also supports `array` format). |
…troller-param-in-config
@mfn I implemented everything you mentioned. |
I guess we've to run (note: I generated it locally but I can't push to your branch) |
@mfn Yeah, sure ... I updated the baseline. Also, I tried to set proper PHPDoc with PHPStan Array Shape, but unsuccessfully. |
@viktorruskai thanks! Unfortunately the baseline needs to be generated with the same PHP version running on GHA, which is 8.1 and not 7.4 I fixed this with #916 , which included your PR 🎉 Thanks for your contribution! |
Summary
Type of change:
Checklist:
composer fix-style