Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No configuration for schema '' found" when route prefix is empty string #888

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Fix "No configuration for schema '' found" when route prefix is empty string #888

merged 1 commit into from
Jan 27, 2022

Conversation

hello-liang-shan
Copy link
Contributor

Summary

Rebing\GraphQL\Exception\SchemaNotFound: No configuration for schema '' found is thrown if route prefix is empty string.

<?php

return [
    'route' => [
        'prefix' => '',
        ...
    ],
    ...
];

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist:

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@hello-liang-shan hello-liang-shan changed the title Fix "No configuration for schema '' found" when route prefix is empty… Fix "No configuration for schema '' found" when route prefix is empty string Jan 26, 2022
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there 👋🏼

Thank you, this LGTM!

@mfn mfn merged commit 41d1418 into rebing:master Jan 27, 2022
@mfn
Copy link
Collaborator

mfn commented Jan 27, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants