make it easier to extend select fields #799
Conversation
|
I am getting different phpstan and phpcs-fixer errors than the pipeline. Also after running composer update |
|
|
||
| protected function selectFieldClass(): string | ||
| { | ||
| return SelectFields::class; |
There was a problem hiding this comment.
boom
This means we're agreeing and opening the SelectFields class to the world and encourage extending from it.
I think given the state of complexity and (missing) test coverage of that class, It's not unreasonable to say this is probably my worst nightmare 😄
I'm in favour of the PR, but let me sort out the other issues first please; will get back to you.
There was a problem hiding this comment.
Np, my plan in the long run is to hack less in this file and instead make prs that might benefit others. But right now this would help me to more easily see the actually changes I have made from the code I just copied over because of dependencies.
|
Sorry I can't promise I can finalize this one, see #800 |
No hurry. Have a great holiday🏝 |
Summary
It is pretty hard to extend select fields at this moment, you need to copy the whole orignalResolver over. This should make it a lot easier.
Type of change:
Checklist:
composer fix-style