[5.x] PHP 8 compatibility #686

mfn · 2020-11-13T10:22:47Z

Summary

See also #687 for the same directly for the master/6.x branch, but ideally we can make this one working and merge it up.

Unclear: can't make tests work with PHP8/L6 (also a problem of #687 )

TODO

BadMethodCallException: Method Illuminate\Http\Response::getData does not exist.
TypeError: GraphQL\Utils\AST::valueFromAST(): Argument #2 ($type) must be of type GraphQL\Type\Definition\InputType, null given, called in /home/runner/work/graphql-laravel/graphql-laravel/vendor/webonyx/graphql-php/src/Executor/Values.php on line 229

=> both these errors where fixed via #689

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

Existing tests have been adapted and/or new tests have been added
Add a CHANGELOG.md entry
Update the README.md
Code style has been fixed via composer fix-style

And not required for these tests

The `realpath()` currently causes issues when testing, as in tests we mock the `copy` and don't perform it, leading `realpath()` being called on a non-existent path and thus passing `false` to `str_replace` as 3rd arg and thus breaking it in PHP 8. This will impact the functionality, just the output won't be as nice; at least for now.

mfn · 2020-11-14T00:49:18Z

And we're green \o/

mfn · 2020-11-14T00:50:00Z

Too bad, forgot I still have PHP8 with L6/L7 excluded

This reverts commit aed7a53

Not sure where the dependency hell problem is and how to solve it. From the failed GHA: ``` Your requirements could not be resolved to an installable set of packages. Error: Your requirements could not be resolved to an installable set of packages. Problem 1 - Conclusion: don't install laravel/framework v6.20.0 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.1 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.2 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.3 (conflict analysis result) - Conclusion: don't install illuminate/contracts 6.x-dev (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.0 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.1 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.2 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.3 (conflict analysis result) - orchestra/testbench[v3.5.0, ..., 3.5.x-dev] require phpunit/phpunit ~6.0 -> satisfiable by phpunit/phpunit[6.0.0, ..., 6.5.14]. - orchestra/testbench v4.0.1 requires phpunit/phpunit ^8.3 -> satisfiable by phpunit/phpunit[8.3.0, ..., 8.5.x-dev]. - orchestra/testbench[v3.9.0, ..., 3.9.x-dev, v4.0.0] require phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, ..., 8.5.x-dev]. - orchestra/testbench[v3.6.6, ..., 3.6.x-dev] require laravel/framework ~5.6.34 -> satisfiable by laravel/framework[v5.6.34, ..., 5.6.x-dev]. - orchestra/testbench[v3.6.4, ..., v3.6.5] require laravel/framework ~5.6.13 -> satisfiable by laravel/framework[v5.6.13, ..., 5.6.x-dev]. - orchestra/testbench v3.6.3 requires laravel/framework ~5.6.5 -> satisfiable by laravel/framework[v5.6.5, ..., 5.6.x-dev]. - orchestra/testbench[v3.6.1, ..., v3.6.2] require laravel/framework ~5.6.4 -> satisfiable by laravel/framework[v5.6.4, ..., 5.6.x-dev]. - orchestra/testbench v3.6.0 requires laravel/framework ~5.6.0 -> satisfiable by laravel/framework[v5.6.0, ..., 5.6.x-dev]. - orchestra/testbench[v3.7.7, ..., 3.7.x-dev] require laravel/framework ~5.7.28 -> satisfiable by laravel/framework[v5.7.28, v5.7.29, 5.7.x-dev]. - orchestra/testbench v3.7.6 requires laravel/framework ~5.7.14 -> satisfiable by laravel/framework[v5.7.14, ..., 5.7.x-dev]. - orchestra/testbench[v3.7.1, ..., v3.7.5] require laravel/framework ~5.7.4 -> satisfiable by laravel/framework[v5.7.4, ..., 5.7.x-dev]. - orchestra/testbench v3.7.0 requires laravel/framework ~5.7.0 -> satisfiable by laravel/framework[v5.7.0, ..., 5.7.x-dev]. - orchestra/testbench[v3.8.5, ..., 3.8.x-dev] require laravel/framework ~5.8.35 -> satisfiable by laravel/framework[v5.8.35, ..., 5.8.x-dev]. - orchestra/testbench[v3.8.3, ..., v3.8.4] require laravel/framework ~5.8.19 -> satisfiable by laravel/framework[v5.8.19, ..., 5.8.x-dev]. - orchestra/testbench v3.8.2 requires laravel/framework ~5.8.3 -> satisfiable by laravel/framework[v5.8.3, ..., 5.8.x-dev]. - orchestra/testbench v3.8.1 requires laravel/framework ~5.8.2 -> satisfiable by laravel/framework[v5.8.2, ..., 5.8.x-dev]. - orchestra/testbench v3.8.0 requires laravel/framework ~5.8.0 -> satisfiable by laravel/framework[v5.8.0, ..., 5.8.x-dev]. - phpunit/phpunit[6.0.0, ..., 6.5.14] require php ^7.0 -> your php version (8.0.0-dev) does not satisfy that requirement. - phpunit/phpunit[8.0.0, ..., 8.5.x-dev] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - illuminate/contracts[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v5.6.0, ..., 5.8.x-dev] require php ^7.1.3 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v7.0.0, ..., v7.28.4] require php ^7.2.5 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.0.0-dev) does not satisfy that requirement. - orchestra/testbench[v6.0.0, ..., 6.x-dev] require laravel/framework ^8.0 -> satisfiable by laravel/framework[v8.0.0, ..., 8.x-dev]. - orchestra/testbench v5.0.2 requires laravel/framework ^7.0.6 -> satisfiable by laravel/framework[v7.0.6, ..., 7.x-dev]. - orchestra/testbench v5.0.1 requires laravel/framework ^7.0.1 -> satisfiable by laravel/framework[v7.0.1, ..., 7.x-dev]. - orchestra/testbench v5.0.0 requires laravel/framework ^7.0 -> satisfiable by laravel/framework[v7.0.0, ..., 7.x-dev]. - Only one of these can be installed: laravel/framework[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev], illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it. - Root composer.json requires illuminate/contracts ^6.0 -> satisfiable by illuminate/contracts[v6.0.0, ..., 6.x-dev], laravel/framework[v6.0.0, ..., 6.x-dev]. - Root composer.json requires orchestra/testbench 3.5.*|3.6.*|3.7.*|3.8.*|3.9.*|4.0.*|5.0.*|^6.0 -> satisfiable by orchestra/testbench[v3.5.0, ..., 3.9.x-dev, v4.0.0, v4.0.1, v5.0.0, v5.0.1, v5.0.2, v6.0.0, ..., 6.x-dev]. Problem 1 - Conclusion: don't install laravel/framework v6.20.0 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.1 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.2 (conflict analysis result) - Conclusion: don't install laravel/framework v6.20.3 (conflict analysis result) - Conclusion: don't install illuminate/contracts 6.x-dev (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.0 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.1 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.2 (conflict analysis result) - Conclusion: don't install illuminate/contracts v6.20.3 (conflict analysis result) - orchestra/testbench[v3.5.0, ..., 3.5.x-dev] require phpunit/phpunit ~6.0 -> satisfiable by phpunit/phpunit[6.0.0, ..., 6.5.14]. - orchestra/testbench v4.0.1 requires phpunit/phpunit ^8.3 -> satisfiable by phpunit/phpunit[8.3.0, ..., 8.5.x-dev]. - orchestra/testbench[v3.9.0, ..., 3.9.x-dev, v4.0.0] require phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, ..., 8.5.x-dev]. - orchestra/testbench[v3.6.6, ..., 3.6.x-dev] require laravel/framework ~5.6.34 -> satisfiable by laravel/framework[v5.6.34, ..., 5.6.x-dev]. - orchestra/testbench[v3.6.4, ..., v3.6.5] require laravel/framework ~5.6.13 -> satisfiable by laravel/framework[v5.6.13, ..., 5.6.x-dev]. - orchestra/testbench v3.6.3 requires laravel/framework ~5.6.5 -> satisfiable by laravel/framework[v5.6.5, ..., 5.6.x-dev]. - orchestra/testbench[v3.6.1, ..., v3.6.2] require laravel/framework ~5.6.4 -> satisfiable by laravel/framework[v5.6.4, ..., 5.6.x-dev]. - orchestra/testbench v3.6.0 requires laravel/framework ~5.6.0 -> satisfiable by laravel/framework[v5.6.0, ..., 5.6.x-dev]. - orchestra/testbench[v3.7.7, ..., 3.7.x-dev] require laravel/framework ~5.7.28 -> satisfiable by laravel/framework[v5.7.28, v5.7.29, 5.7.x-dev]. - orchestra/testbench v3.7.6 requires laravel/framework ~5.7.14 -> satisfiable by laravel/framework[v5.7.14, ..., 5.7.x-dev]. - orchestra/testbench[v3.7.1, ..., v3.7.5] require laravel/framework ~5.7.4 -> satisfiable by laravel/framework[v5.7.4, ..., 5.7.x-dev]. - orchestra/testbench v3.7.0 requires laravel/framework ~5.7.0 -> satisfiable by laravel/framework[v5.7.0, ..., 5.7.x-dev]. - orchestra/testbench[v3.8.5, ..., 3.8.x-dev] require laravel/framework ~5.8.35 -> satisfiable by laravel/framework[v5.8.35, ..., 5.8.x-dev]. - orchestra/testbench[v3.8.3, ..., v3.8.4] require laravel/framework ~5.8.19 -> satisfiable by laravel/framework[v5.8.19, ..., 5.8.x-dev]. - orchestra/testbench v3.8.2 requires laravel/framework ~5.8.3 -> satisfiable by laravel/framework[v5.8.3, ..., 5.8.x-dev]. - orchestra/testbench v3.8.1 requires laravel/framework ~5.8.2 -> satisfiable by laravel/framework[v5.8.2, ..., 5.8.x-dev]. - orchestra/testbench v3.8.0 requires laravel/framework ~5.8.0 -> satisfiable by laravel/framework[v5.8.0, ..., 5.8.x-dev]. - phpunit/phpunit[6.0.0, ..., 6.5.14] require php ^7.0 -> your php version (8.0.0-dev) does not satisfy that requirement. - phpunit/phpunit[8.0.0, ..., 8.5.x-dev] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - illuminate/contracts[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v5.6.0, ..., 5.8.x-dev] require php ^7.1.3 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v7.0.0, ..., v7.28.4] require php ^7.2.5 -> your php version (8.0.0-dev) does not satisfy that requirement. - laravel/framework[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.0.0-dev) does not satisfy that requirement. - orchestra/testbench[v6.0.0, ..., 6.x-dev] require laravel/framework ^8.0 -> satisfiable by laravel/framework[v8.0.0, ..., 8.x-dev]. - orchestra/testbench v5.0.2 requires laravel/framework ^7.0.6 -> satisfiable by laravel/framework[v7.0.6, ..., 7.x-dev]. - orchestra/testbench v5.0.1 requires laravel/framework ^7.0.1 -> satisfiable by laravel/framework[v7.0.1, ..., 7.x-dev]. - orchestra/testbench v5.0.0 requires laravel/framework ^7.0 -> satisfiable by laravel/framework[v7.0.0, ..., 7.x-dev]. - Only one of these can be installed: laravel/framework[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev], illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it. - Root composer.json requires illuminate/contracts ^6.0 -> satisfiable by illuminate/contracts[v6.0.0, ..., 6.x-dev], laravel/framework[v6.0.0, ..., 6.x-dev]. - Root composer.json requires orchestra/testbench 3.5.*|3.6.*|3.7.*|3.8.*|3.9.*|4.0.*|5.0.*|^6.0 -> satisfiable by orchestra/testbench[v3.5.0, ..., 3.9.x-dev, v4.0.0, v4.0.1, v5.0.0, v5.0.1, v5.0.2, v6.0.0, ..., 6.x-dev]. Error: Process completed with exit code 2. ```

mfn · 2020-11-14T01:03:09Z

PHP8/L7 checks out, though I don't know why PHP8/L6 doesn't => I can't make sense of this dependency conflict:

Your requirements could not be resolved to an installable set of packages.
Error: Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Conclusion: don't install laravel/framework v6.20.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.3 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts 6.x-dev (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.0 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.1 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.2 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.3 (conflict analysis result)
    - orchestra/testbench[v3.5.0, ..., 3.5.x-dev] require phpunit/phpunit ~6.0 -> satisfiable by phpunit/phpunit[6.0.0, ..., 6.5.14].
    - orchestra/testbench v4.0.1 requires phpunit/phpunit ^8.3 -> satisfiable by phpunit/phpunit[8.3.0, ..., 8.5.x-dev].
    - orchestra/testbench[v3.9.0, ..., 3.9.x-dev, v4.0.0] require phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, ..., 8.5.x-dev].
    - orchestra/testbench[v3.6.6, ..., 3.6.x-dev] require laravel/framework ~5.6.34 -> satisfiable by laravel/framework[v5.6.34, ..., 5.6.x-dev].
    - orchestra/testbench[v3.6.4, ..., v3.6.5] require laravel/framework ~5.6.13 -> satisfiable by laravel/framework[v5.6.13, ..., 5.6.x-dev].
    - orchestra/testbench v3.6.3 requires laravel/framework ~5.6.5 -> satisfiable by laravel/framework[v5.6.5, ..., 5.6.x-dev].
    - orchestra/testbench[v3.6.1, ..., v3.6.2] require laravel/framework ~5.6.4 -> satisfiable by laravel/framework[v5.6.4, ..., 5.6.x-dev].
    - orchestra/testbench v3.6.0 requires laravel/framework ~5.6.0 -> satisfiable by laravel/framework[v5.6.0, ..., 5.6.x-dev].
    - orchestra/testbench[v3.7.7, ..., 3.7.x-dev] require laravel/framework ~5.7.28 -> satisfiable by laravel/framework[v5.7.28, v5.7.29, 5.7.x-dev].
    - orchestra/testbench v3.7.6 requires laravel/framework ~5.7.14 -> satisfiable by laravel/framework[v5.7.14, ..., 5.7.x-dev].
    - orchestra/testbench[v3.7.1, ..., v3.7.5] require laravel/framework ~5.7.4 -> satisfiable by laravel/framework[v5.7.4, ..., 5.7.x-dev].
    - orchestra/testbench v3.7.0 requires laravel/framework ~5.7.0 -> satisfiable by laravel/framework[v5.7.0, ..., 5.7.x-dev].
    - orchestra/testbench[v3.8.5, ..., 3.8.x-dev] require laravel/framework ~5.8.35 -> satisfiable by laravel/framework[v5.8.35, ..., 5.8.x-dev].
    - orchestra/testbench[v3.8.3, ..., v3.8.4] require laravel/framework ~5.8.19 -> satisfiable by laravel/framework[v5.8.19, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.2 requires laravel/framework ~5.8.3 -> satisfiable by laravel/framework[v5.8.3, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.1 requires laravel/framework ~5.8.2 -> satisfiable by laravel/framework[v5.8.2, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.0 requires laravel/framework ~5.8.0 -> satisfiable by laravel/framework[v5.8.0, ..., 5.8.x-dev].
    - phpunit/phpunit[6.0.0, ..., 6.5.14] require php ^7.0 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - phpunit/phpunit[8.0.0, ..., 8.5.x-dev] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - illuminate/contracts[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v5.6.0, ..., 5.8.x-dev] require php ^7.1.3 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v7.0.0, ..., v7.28.4] require php ^7.2.5 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - orchestra/testbench[v6.0.0, ..., 6.x-dev] require laravel/framework ^8.0 -> satisfiable by laravel/framework[v8.0.0, ..., 8.x-dev].
    - orchestra/testbench v5.0.2 requires laravel/framework ^7.0.6 -> satisfiable by laravel/framework[v7.0.6, ..., 7.x-dev].
    - orchestra/testbench v5.0.1 requires laravel/framework ^7.0.1 -> satisfiable by laravel/framework[v7.0.1, ..., 7.x-dev].
    - orchestra/testbench v5.0.0 requires laravel/framework ^7.0 -> satisfiable by laravel/framework[v7.0.0, ..., 7.x-dev].
    - Only one of these can be installed: laravel/framework[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev], illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it.
    - Root composer.json requires illuminate/contracts ^6.0 -> satisfiable by illuminate/contracts[v6.0.0, ..., 6.x-dev], laravel/framework[v6.0.0, ..., 6.x-dev].
    - Root composer.json requires orchestra/testbench 3.5.*|3.6.*|3.7.*|3.8.*|3.9.*|4.0.*|5.0.*|^6.0 -> satisfiable by orchestra/testbench[v3.5.0, ..., 3.9.x-dev, v4.0.0, v4.0.1, v5.0.0, v5.0.1, v5.0.2, v6.0.0, ..., 6.x-dev].


  Problem 1
    - Conclusion: don't install laravel/framework v6.20.0 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.1 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.2 (conflict analysis result)
    - Conclusion: don't install laravel/framework v6.20.3 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts 6.x-dev (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.0 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.1 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.2 (conflict analysis result)
    - Conclusion: don't install illuminate/contracts v6.20.3 (conflict analysis result)
    - orchestra/testbench[v3.5.0, ..., 3.5.x-dev] require phpunit/phpunit ~6.0 -> satisfiable by phpunit/phpunit[6.0.0, ..., 6.5.14].
    - orchestra/testbench v4.0.1 requires phpunit/phpunit ^8.3 -> satisfiable by phpunit/phpunit[8.3.0, ..., 8.5.x-dev].
    - orchestra/testbench[v3.9.0, ..., 3.9.x-dev, v4.0.0] require phpunit/phpunit ^8.0 -> satisfiable by phpunit/phpunit[8.0.0, ..., 8.5.x-dev].
    - orchestra/testbench[v3.6.6, ..., 3.6.x-dev] require laravel/framework ~5.6.34 -> satisfiable by laravel/framework[v5.6.34, ..., 5.6.x-dev].
    - orchestra/testbench[v3.6.4, ..., v3.6.5] require laravel/framework ~5.6.13 -> satisfiable by laravel/framework[v5.6.13, ..., 5.6.x-dev].
    - orchestra/testbench v3.6.3 requires laravel/framework ~5.6.5 -> satisfiable by laravel/framework[v5.6.5, ..., 5.6.x-dev].
    - orchestra/testbench[v3.6.1, ..., v3.6.2] require laravel/framework ~5.6.4 -> satisfiable by laravel/framework[v5.6.4, ..., 5.6.x-dev].
    - orchestra/testbench v3.6.0 requires laravel/framework ~5.6.0 -> satisfiable by laravel/framework[v5.6.0, ..., 5.6.x-dev].
    - orchestra/testbench[v3.7.7, ..., 3.7.x-dev] require laravel/framework ~5.7.28 -> satisfiable by laravel/framework[v5.7.28, v5.7.29, 5.7.x-dev].
    - orchestra/testbench v3.7.6 requires laravel/framework ~5.7.14 -> satisfiable by laravel/framework[v5.7.14, ..., 5.7.x-dev].
    - orchestra/testbench[v3.7.1, ..., v3.7.5] require laravel/framework ~5.7.4 -> satisfiable by laravel/framework[v5.7.4, ..., 5.7.x-dev].
    - orchestra/testbench v3.7.0 requires laravel/framework ~5.7.0 -> satisfiable by laravel/framework[v5.7.0, ..., 5.7.x-dev].
    - orchestra/testbench[v3.8.5, ..., 3.8.x-dev] require laravel/framework ~5.8.35 -> satisfiable by laravel/framework[v5.8.35, ..., 5.8.x-dev].
    - orchestra/testbench[v3.8.3, ..., v3.8.4] require laravel/framework ~5.8.19 -> satisfiable by laravel/framework[v5.8.19, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.2 requires laravel/framework ~5.8.3 -> satisfiable by laravel/framework[v5.8.3, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.1 requires laravel/framework ~5.8.2 -> satisfiable by laravel/framework[v5.8.2, ..., 5.8.x-dev].
    - orchestra/testbench v3.8.0 requires laravel/framework ~5.8.0 -> satisfiable by laravel/framework[v5.8.0, ..., 5.8.x-dev].
    - phpunit/phpunit[6.0.0, ..., 6.5.14] require php ^7.0 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - phpunit/phpunit[8.0.0, ..., 8.5.x-dev] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - illuminate/contracts[v6.0.0, ..., v6.19.1] require php ^7.2 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v5.6.0, ..., 5.8.x-dev] require php ^7.1.3 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v7.0.0, ..., v7.28.4] require php ^7.2.5 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - laravel/framework[v8.0.0, ..., v8.11.2] require php ^7.3 -> your php version (8.0.0-dev) does not satisfy that requirement.
    - orchestra/testbench[v6.0.0, ..., 6.x-dev] require laravel/framework ^8.0 -> satisfiable by laravel/framework[v8.0.0, ..., 8.x-dev].
    - orchestra/testbench v5.0.2 requires laravel/framework ^7.0.6 -> satisfiable by laravel/framework[v7.0.6, ..., 7.x-dev].
    - orchestra/testbench v5.0.1 requires laravel/framework ^7.0.1 -> satisfiable by laravel/framework[v7.0.1, ..., 7.x-dev].
    - orchestra/testbench v5.0.0 requires laravel/framework ^7.0 -> satisfiable by laravel/framework[v7.0.0, ..., 7.x-dev].
    - Only one of these can be installed: laravel/framework[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev], illuminate/support[v5.5.0, ..., 5.8.x-dev, v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev]. laravel/framework replaces illuminate/support and thus cannot coexist with it.
    - Root composer.json requires illuminate/contracts ^6.0 -> satisfiable by illuminate/contracts[v6.0.0, ..., 6.x-dev], laravel/framework[v6.0.0, ..., 6.x-dev].
    - Root composer.json requires orchestra/testbench 3.5.*|3.6.*|3.7.*|3.8.*|3.9.*|4.0.*|5.0.*|^6.0 -> satisfiable by orchestra/testbench[v3.5.0, ..., 3.9.x-dev, v4.0.0, v4.0.1, v5.0.0, v5.0.1, v5.0.2, v6.0.0, ..., 6.x-dev].

Error: Process completed with exit code 2.

mfn self-assigned this Nov 13, 2020

mfn force-pushed the mfn-5.x-php8 branch from fe9ed5f to daf5e2e Compare November 13, 2020 10:25

This was referenced Nov 13, 2020

[6.x] PHP 8 compatibility #687

Closed

tests: fix definition of some args missing the type key #689

Merged

mfn added 6 commits November 14, 2020 01:42

gha: add PHP 8 to the test matrix

fb5560d

composer: allow PHPUnit 9 for PHP8

16289cb

gha: remove php-cs-fixer currently version incompatible with PHP8

84bced7

And not required for these tests

gha: start small and see if PHP8 works with L8 here

aed7a53

Fix "Method ReflectionParameter::getClass() is deprecated"

cabb312

mfn force-pushed the mfn-5.x-php8 branch from 7e4bd37 to 2160949 Compare November 14, 2020 00:42

gha: see if the problem with integration tests is related to composer v2

9f3d407

mfn marked this pull request as ready for review November 14, 2020 00:49

mfn added 2 commits November 14, 2020 01:50

Revert "gha: start small and see if PHP8 works with L8 here"

0fef3e2

This reverts commit aed7a53

Update changelog

4577d74

mfn merged commit df3c361 into rebing:5.x Nov 16, 2020

mfn deleted the mfn-5.x-php8 branch November 16, 2020 06:44

mfn restored the mfn-5.x-php8 branch November 16, 2020 06:44

mfn deleted the mfn-5.x-php8 branch November 16, 2020 06:44

mfn mentioned this pull request Nov 16, 2020

[6.x] Merge 5.x into master/6.x #692

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[5.x] PHP 8 compatibility #686

[5.x] PHP 8 compatibility #686

mfn commented Nov 13, 2020 •

edited

Loading

mfn commented Nov 14, 2020

mfn commented Nov 14, 2020 •

edited

Loading

mfn commented Nov 14, 2020

[5.x] PHP 8 compatibility #686

[5.x] PHP 8 compatibility #686

Conversation

mfn commented Nov 13, 2020 • edited Loading

Summary

TODO

Type of change

Checklist

mfn commented Nov 14, 2020

mfn commented Nov 14, 2020 • edited Loading

mfn commented Nov 14, 2020

mfn commented Nov 13, 2020 •

edited

Loading

mfn commented Nov 14, 2020 •

edited

Loading