Generate SyntaxError instead of Exception for empty queries [5.x] #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Finally merged 😅 @plivius apologies for the long wait, the change will be included in the next (and probably final) 5.x release, which I intend to cut after the PHP8 release expected this week. I did massage the test slightly in c404c57 , I wasn't quite happy with the naming and some style. Hope that's fine with you 🤞 |
|
@mfn Great, thanks for merging, glad it made it through! 😄 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #680, against base
5.xType of change
Checklist
composer fix-style