Fix infinite loop #579
Fix infinite loop #579
Conversation
crissi
force-pushed
the
fix_infinite_loop
branch
2 times, most recently
from
de79c2e to
5c58aee
Compare
|
Ok! That one looks massive… |
|
Sorry for the long wait, I've looked into the high level functionality: very cool, totally want to merge this! Going now through the code for giving detailed feedback. |
|
All cool, take your time😊
Hent Outlook til iOS<https://aka.ms/o0ukef>
…________________________________
Fra: Markus Podar <[email protected]>
Sendt: Saturday, January 25, 2020 8:46:00 PM
Til: rebing/graphql-laravel <[email protected]>
Cc: Christian <[email protected]>; Author <[email protected]>
Emne: Re: [rebing/graphql-laravel] Fix infinite loop (#579)
Sorry for the long wait, I've looked into the high level functionality: very cool, totally want to merge this!
Going now through the code for giving detailed feedback.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#579?email_source=notifications&email_token=AAXPDYVS7BBDQGTVFAVD6HDQ7SJHRA5CNFSM4KI3RZAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5D7YQ#issuecomment-578437090>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAXPDYUYIEMR3EGTHUCC62TQ7SJHRANCNFSM4KI3RZAA>.
|
There was a problem hiding this comment.
I didn't see any issues with the general implementation!
However I'm not super happy with some aspects of the under-documented types, especially arrays
I therefore now updated larastan which depends on a newer phpstan version which is much more strict in this regard. But since generates > 600 errors on master, I added a baseline file; meaning only new code parts will trigger such phpstan errors => like this PR likely will do.
This is kind of an experiment, if it's not working out, I'll remove it.
For that reason, and the in the meantime also updated changelog.md, please rebase with master and add a changelog entry => well deserved :)
crissi
force-pushed
the
fix_infinite_loop
branch
from
904f4a6 to
1350343
Compare
|
updated |
|
https://github.com/rebing/graphql-laravel/releases/tag/5.0.0 has been released which includes this! |
Summary
Fixes #512
Fix the infinite loop as well as sending the correct matching input data to the rule-callback.
If people have been using rule-callback in a nested input object, the input to the object was before always the full input, now the input data matches the level of nesting.
Type of change